Fix SourceGen NullReferenceException for XAML bindings with null intermediate properties #33864
+134
−25
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SourceGen XAML bindings like
{Binding ViewModelProperty.Property}generated setters that throwNullReferenceExceptionwhen intermediate properties are null at runtime—a valid scenario when data loads after page initialization.Changes
CompiledBindingMarkup.cs: Replace
previousPartIsNullablewithpreviousPartIsReferenceTypeto wrap all intermediate reference type accesses inConditionalAccess. XAML paths have no nullability annotations, so all reference types must be treated as potentially null.Setter.cs: Handle value types inside
ConditionalAccesswhen the next part is the final property to set. Structs need pattern matching capture to allow property assignment.Tests: Update existing tests for new conditional access patterns; add regression test for the specific issue scenario.
Before
After
Original prompt
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.