[XSG] Handle NaN values in ThicknessConverter #33872
Open
+90
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #33871 The XAML Source Generator's ThicknessConverter didn't handle special double values like NaN, Infinity, and -Infinity. This is used by Button.Padding to indicate 'use platform default padding'. Changes: - Add TryParseDouble helper that handles NaN, Infinity, -Infinity - Add FormatDouble helper that generates double.NaN etc in code - Add XAML unit test for Padding="NaN"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note
Are you waiting for the changes in this PR to be merged?
It would be very helpful if you could test the resulting artifacts from this PR and let us know in a comment if this change resolves your issue. Thank you!
Description
Fixes #33871
The XAML Source Generator's
ThicknessConverterdidn't handle special double values likeNaN,Infinity, and-Infinity. This is used byButton.Paddingto indicate "use platform default padding" viaPadding="NaN".Changes
TryParseDoublehelper that handlesNaN,Infinity,-Infinityin addition to regular numbersFormatDoublehelper that generatesdouble.NaN,double.PositiveInfinity,double.NegativeInfinityin generated codePadding="NaN"Testing
Maui33871.xamltest that verifiesPadding="NaN"works with all three inflators (Runtime, XamlC, SourceGen)