[XSG] Fix inline StyleSheet CSS content with quotes #33874
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #33867 When inline StyleSheet content contains double quotes (e.g., in CSS placeholder strings), the generated code was malformed because quotes weren't escaped. In a verbatim string literal (@""), quotes must be doubled (""). This fix escapes quotes in the CSS content before generating the code.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes issue #33867 where the XAML Source Generator (XSG) generated malformed C# code when inline StyleSheet content contained double quotes (e.g., CSS placeholder strings like -maui-placeholder: "CSS Placeholder";). The fix escapes double quotes for verbatim string literals by doubling them (" → ""), which is the correct C# syntax for embedding quotes within verbatim string literals (@"...").
Changes:
- Added quote escaping in
KnownMarkups.csfor inline StyleSheet CSS content - Added comprehensive test (
Maui33867.xamland.xaml.cs) that validates the fix with both runtime and source generation
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
src/Controls/src/SourceGen/KnownMarkups.cs |
Escapes double quotes in CSS content before embedding in generated verbatim string literal |
src/Controls/tests/Xaml.UnitTests/Issues/Maui33867.xaml |
Test XAML file with inline StyleSheet containing CSS with quoted placeholder text |
src/Controls/tests/Xaml.UnitTests/Issues/Maui33867.xaml.cs |
xUnit test that verifies SourceGen compiles without errors and runtime inflation works correctly |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note
Are you waiting for the changes in this PR to be merged?
It would be very helpful if you could test the resulting artifacts from this PR and let us know in a comment if this change resolves your issue. Thank you!
Description
Fixes #33867
When inline StyleSheet content contains double quotes (e.g., in CSS placeholder strings like
-maui-placeholder: "CSS Placeholder";), XSG was generating malformed C# code. The issue was that quotes weren't escaped for verbatim string literals.Changes
In
KnownMarkups.cs, the CSS content is now escaped by replacing"with""before embedding in the generated verbatim string literal.Test
Added
Maui33867.xamltest that includes CSS with quoted content, matching theStyleSheetsPage.xamlfrom the sample app.