Fix CustomSwipeControl sample - add missing event handler #33880
+7
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The XAML references Invoked="OnInvoked" but the handler was missing from the code-behind. Also removed [XamlCompilation(Skip)] as it's no longer needed.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a compilation error in the CustomSwipeControl sample that occurred when using XAML Source Generator (XSG). The XAML file referenced an event handler OnInvoked for a SwipeItem's Invoked event, but the handler was missing from the code-behind file.
Changes:
- Added the missing
OnInvokedevent handler to handle SwipeItem invocation - Removed the
[XamlCompilation(XamlCompilationOptions.Skip)]attribute, which was previously required to skip compilation due to the missing handler - Updated using statements to include
Systemnamespace (required for EventArgs) and removed unusedMicrosoft.Maui.Controls.Xamlnamespace
...ontrols/samples/Controls.Sample/Pages/Controls/SwipeViewGalleries/CustomSwipeControl.xaml.cs
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note
Are you waiting for the changes in this PR to be merged?
It would be very helpful if you could test the resulting artifacts from this PR and let us know in a comment if this change resolves your issue. Thank you!
Description
The XAML file references
Invoked="OnInvoked"on a SwipeItem, but the handler was missing from the code-behind. This caused XSG (XAML Source Generator) to report an error when trying to compile the sample with SourceGen.Changes
OnInvokedevent handler toCustomSwipeControl.xaml.cs[XamlCompilation(XamlCompilationOptions.Skip)]attribute since the file can now be compiled properlyFixes #33877