Remove web project configuration check #12785
Open
+0
−13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR removes legacy support for old-style web projects that lack proper configuration mappings in solution files. The removed code provided a workaround for web projects missing specific configurations (typically Release) by checking if a solution configuration exists and allowing the build to proceed anyway.
- Simplifies the
WouldProjectBuildmethod by removing a web project-specific code path - Makes configuration handling consistent across all project types
- Removes approximately 15 lines of conditional logic
Member
|
We'd have to check with VS to see what the support policy on those projects is. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@rainersigwald When we last discussed this check, you mentioned this was relevant for really old kinds of web projects. I'm guessing it might be safe to accept removing this hack? What do you think?