Fix WinFX casing and targets import#5425
Closed
Nirmal4G wants to merge 4 commits intodotnet:masterfrom
Nirmal4G:hotfix/refactor-WinFX
Closed
Fix WinFX casing and targets import#5425Nirmal4G wants to merge 4 commits intodotnet:masterfrom Nirmal4G:hotfix/refactor-WinFX
Nirmal4G wants to merge 4 commits intodotnet:masterfrom
Nirmal4G:hotfix/refactor-WinFX
Conversation
'WinFX' is the correct casing as observed in the .NET CLR 2 frameworks
In project files, scripts, comments, etc...
However, the correct casing is 'WinFX', as observed in the .NET CLR 2 framework disk layout. This is similar to, what the F# team used in their targets, to cope with the case-sensitive file-systems. Make sure to let others know that we're importing NETFX's WinFX targets instead.
for only previously changed files (in this Patch tree) Conforming to the repository's EditorConfig file
Contributor
Author
|
Commenter does not have sufficient privileges for PR 5425 in repo microsoft/msbuild |
rainersigwald
requested changes
Jun 18, 2020
Member
rainersigwald
left a comment
rainersigwald
left a comment
There was a problem hiding this comment.
Team triage: As in #5346, we don't think this fix is worth making.
Contributor
Author
|
@rainersigwald please read the PR carefully. It's not exactly the same one as before. As you've said, the casing was different. So, I fixed it to support both the cases. I made sure that we would not regress anything. Also, I've made changes to the way the Please reconsider and reopen this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I brought all the changes from #5346 and fixed import of
WinFXtargets on case-sensitive file-system and then updated #5200 logic.msbuild/src/Tasks/Microsoft.NETFramework.CurrentVersion.targets
Line 129 in 26f6d1d
msbuild/src/Tasks/Microsoft.Common.CurrentVersion.targets
Line 6151 in 26f6d1d
These targets point to
WinFXcasing but hasWinFxcasing in theMSBuildToolsPath. This will result in file not found, if the targets get imported in a case-sensitive file-system. Since, no one used WinFX targets on Mono, they have not been reported, I think.Also NETFX 2 has
WinFXcasing but NETFX 4 hasWinFxcasing. So, In order to cope with bothWinFXandWinFx, I renamed the redirection targets to the correct case and then added a workaround which F# team uses to import either ones on a case-sensitive file system.