Fix Windows Helix work item exit code and prerequisite error handling #5075
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Use 'call deactivate' instead of 'deactivate' in PostCommands on Windows. Without 'call', the batch file transfers control to deactivate.bat and never returns, causing EXIT /b %_commandExitCode% to never execute. - Chain Windows prerequisite install commands with && and add error checking. Previously, pip install failures were silently ignored, causing ModuleNotFoundError for azure packages during upload.
matouskozak
previously approved these changes
Jan 7, 2026
LoopedBard3
previously approved these changes
Jan 8, 2026
Member
LoopedBard3
left a comment
LoopedBard3
left a comment
There was a problem hiding this comment.
Looks good, should make sure to do a test run before merging.
Member
DrewScoggins
dismissed stale reviews from LoopedBard3 and matouskozak
via
ecd14eb
LoopedBard3
approved these changes
Jan 9, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use 'call deactivate' instead of 'deactivate' in PostCommands on Windows. Without 'call', the batch file transfers control to deactivate.bat and never returns, causing EXIT /b %_commandExitCode% to never execute.
Chain Windows prerequisite install commands with && and add error checking. Previously, pip install failures were silently ignored, causing ModuleNotFoundError for azure packages during upload.