Simpler fix for FUTD check of copy items when building for debug#9133
Draft
drewnoakes wants to merge 1 commit intodotnet:mainfrom
Draft
Simpler fix for FUTD check of copy items when building for debug#9133drewnoakes wants to merge 1 commit intodotnet:mainfrom
drewnoakes wants to merge 1 commit intodotnet:mainfrom
Conversation
The previous fix is fine, however this is slightly more elegant and avoids raising fake events to make things work. In the F5 case, the SBM does fire `IVsUpdateSolutionEvents.UpdateSolution_Begin` before calling the FUTDC, so changing our implementation to use that event means we construct the `SolutionBuildContext` correctly, even when the SBM calls the FUTDC twice.
drewnoakes
added
the
Feature-Up-to-date
Member
Author
|
Marking as draft. I will publish it once 17.7p3 has been finalized, for inclusion in 17.7p4. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an alternative implementation of #9130 that also fixes #9124, but in a slightly cleaner way.
The previous fix is fine, however this is slightly more elegant and avoids raising fake events to make things work.
In the F5 case, the SBM does fire
IVsUpdateSolutionEvents.UpdateSolution_Beginbefore calling the FUTDC, so changing our implementation to use that event means we construct theSolutionBuildContextcorrectly, even when the SBM calls the FUTDC twice.Microsoft Reviewers: Open in CodeFlow