Skip to content

Change Span of PutFullAccessorOnOwnLine to be correct #1661

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
josefpihrt merged 5 commits into from
Aug 24, 2025
+7 −9
Merged

Change Span of PutFullAccessorOnOwnLine to be correct #1661

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
a036c4b
Change Span of PutFullAccessorOnOwnLine to be correct
ua-niekschoemaker Jun 20, 2025
e172c88
Merge branch 'main' of github.com:niekschoemaker/roslynator
ua-niekschoemaker Jun 20, 2025
80fb8e4
Merge branch 'main' into main
josefpihrt Jul 26, 2025
9cc2ca4
Merge branch 'main' into main
josefpihrt Aug 8, 2025
54db84a
Fix diagnostic location for PutFullAccessorOnItsOwnLine rule and upda…
ua-niekschoemaker Aug 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions src/Formatting.Analyzers/CSharp/AccessorListAnalyzer.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,9 +59,7 @@ private static void AnalyzeAccessorList(SyntaxNodeAnalysisContext context)
DiagnosticHelpers.ReportDiagnostic(
context,
DiagnosticRules.PutFullAccessorOnItsOwnLine,
Location.Create(accessor.SyntaxTree, new TextSpan(accessor.SpanStart, 0)));

break;
Location.Create(accessor.SyntaxTree, accessor.Span));
}

token = accessor.Body?.CloseBraceToken ?? accessor.SemicolonToken;
Expand Down
12 changes: 6 additions & 6 deletions src/Tests/Formatting.Analyzers.Tests/RCS0025PutFullAccessorOnItsOwnLineTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ class C
{
private string _p;

public string P { [||]get { return _p; } set { _p = value; } }
public string P { [|get { return _p; }|] [|set { _p = value; }|] }
}
", @"
class C
Expand All @@ -46,7 +46,7 @@ class C

public string P
{
get { return _p; } [||]set { _p = value; }
get { return _p; } [|set { _p = value; }|]
}
}
", @"
Expand All @@ -71,7 +71,7 @@ class C
{
private string _p;

public string P { [||]get => _p; set => _p = value; }
public string P { [|get => _p;|] [|set => _p = value;|] }
}
", @"
class C
Expand All @@ -97,7 +97,7 @@ class C

public string P
{
get => _p; [||]set => _p = value;
get => _p; [|set => _p = value;|]
}
}
", @"
Expand All @@ -122,7 +122,7 @@ class C
{
private string _p;

public string P { [||]get { return _p; } }
public string P { [|get { return _p; }|] }
}
", @"
class C
Expand All @@ -145,7 +145,7 @@ class C
{
private string _p;

public string P { [||]get => _p; }
public string P { [|get => _p;|] }
}
", @"
class C
Expand Down
Loading