JIT: Add support for frozen structs in Swift reverse pinvokes #100344
Conversation
For HVAs the element size can be > 8, but should at most be 8-byte aligned.
|
/azp run runtime-coreclr jitstress, runtime-coreclr jitstressregs |
|
Azure Pipelines successfully started running 2 pipeline(s). |
|
The testing passed, the failure is #99810. Need to fix the formatting failures though. |
|
cc @dotnet/jit-contrib PTAL @amanasifkhalid I think this will need a few fixups after #100429 is merged. Diffs. Enabling implicit byrefs on SysV x64 results in some large TP regressions with an MSVC compiled cross compiler, but the clang compiled one doesn't look bad. Also some TP improvements on other platforms from some of the optimization work I did around the implicit byrefs as a result. |
| case 1: | ||
| return TYP_UBYTE; | ||
| case 2: | ||
| return TYP_USHORT; |
There was a problem hiding this comment.
Why do we use unsigned types for these ones?
There was a problem hiding this comment.
We generally normalize up to at least 4 bytes on all loads, and zero extensions sometimes have smaller encodings than sign extensions on xarch (similar change was made in #86631).
|
I'll kick off the stress pipelines again just to be safe after the merge of #100429. |
|
/azp run runtime-coreclr jitstress, runtime-coreclr jitstressregs, runtime-coreclr jitstress2-jitstressregs |
|
Azure Pipelines successfully started running 3 pipeline(s). |
|
Also cc @jkoritzinsky, @jkurdek, @matouskozak, @kotlarmilos. With this PR I think we'll be feature complete on the Swift support in RyuJIT (until #100543 makes it through review, although I expect it will be straightforward to add support for those). |
…#100344) This adds the final support for frozen structs in UCO methods. This passes 2500 auto generated tests locally on both macOS x64 and arm64. This PR includes only 100 tests. Frozen struct parameters are handled via the new ABI representation added in dotnet#100138. When such a parameter exists we always allocate space for it on the local stack frame. The struct is then reassembled from its passed constituents as the first thing in the codegen. One complication is that there can be an arbitrary amount of codegen to handle this reassembling. We cannot handle an arbitrary amount of codegen in the prolog, so the reassembling is handled in two places. First, since the amount of register passed data is limited, we handle those in the prolog (which frees them up to be used for other things). If some pieces were passed on the stack the JIT then ensures that there is a scratch BB and generates the code to reassemble the remaining parts as the first thing in the scratch BB. Since Swift structs can be passed by reference in certain cases this PR also enables `FEATURE_IMPLICIT_BYREFS` for SysV x64 to handle those cases. Depending on the TP impact we can refine some of the ifdefs around this.
This adds the final support for frozen structs in UCO methods.
This passes 2500 auto generated tests locally on both macOS x64 and arm64. This PR includes only 100 tests.
Frozen struct parameters are handled via the new ABI representation added in #100138. When such a parameter exists we always allocate space for it on the local stack frame. The struct is then reassembled from its passed constituents as the first thing in the codegen.
One complication is that there can be an arbitrary amount of codegen to handle this reassembling. We cannot handle an arbitrary amount of codegen in the prolog, so the reassembling is handled in two places. First, since the amount of register passed data is limited, we handle those in the prolog (which frees them up to be used for other things). If some pieces were passed on the stack the JIT then ensures that there is a scratch BB and generates the code to reassemble the remaining parts as the first thing in the scratch BB.
Since Swift structs can be passed by reference in certain cases this PR also enables
FEATURE_IMPLICIT_BYREFSfor SysV x64 to handle those cases. Depending on the TP impact we can refine some of the ifdefs around this.TODO: