Skip to content

[LoongArch64] Fix the TestVector256() size alignment within src/tests/Interop/StructPacking/StructPacking.cs. #103112

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 6, 2024

Conversation

LuckyXu-HF
Copy link
Contributor

Fix the TestVector256() size alignment within src/tests/Interop/StructPacking/StructPacking.cs.

@ghost ghost added the area-Interop-coreclr label Jun 6, 2024
@dotnet-policy-service dotnet-policy-service bot added the community-contribution Indicates that the PR has been added by a community member label Jun 6, 2024
Copy link
Contributor

@shushanhf shushanhf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Thanks

@LuckyXu-HF
Copy link
Contributor Author

This is to fix the following failed testcase: Interop/Interop/Interop.sh - global::Program.TestEntryPoint()

...
...
14:56:56.156 Running test: global::Program.TestEntryPoint()
Unexpected Size for DefaultLayoutDefaultPacking`1[System.Runtime.Intrinsics.Vector256`1[System.Byte]].
     Expected: 64; Actual: 48
Unexpected Offset for DefaultLayoutDefaultPacking`1[System.Runtime.Intrinsics.Vector256`1[System.Byte]].Value.
     Expected: 32; Actual: 16

Unexpected Size for SequentialLayoutDefaultPacking`1[System.Runtime.Intrinsics.Vector256`1[System.Byte]].
     Expected: 64; Actual: 48
Unexpected Offset for SequentialLayoutDefaultPacking`1[System.Runtime.Intrinsics.Vector256`1[System.Byte]].Value.
     Expected: 32; Actual: 16

Unexpected Size for SequentialLayoutMaxPacking`1[System.Runtime.Intrinsics.Vector256`1[System.Byte]].
     Expected: 64; Actual: 48
Unexpected Offset for SequentialLayoutMaxPacking`1[System.Runtime.Intrinsics.Vector256`1[System.Byte]].Value.
     Expected: 32; Actual: 16

Unexpected Size for AutoLayoutDefaultPacking`1[System.Runtime.Intrinsics.Vector256`1[System.Byte]].
     Expected: 64; Actual: 48
Unexpected Offset for AutoLayoutDefaultPacking`1[System.Runtime.Intrinsics.Vector256`1[System.Byte]].Value.
     Expected: 32; Actual: 16

Unexpected Size for AutoLayoutMinPacking`1[System.Runtime.Intrinsics.Vector256`1[System.Byte]].
     Expected: 64; Actual: 48
Unexpected Offset for AutoLayoutMinPacking`1[System.Runtime.Intrinsics.Vector256`1[System.Byte]].Value.
     Expected: 32; Actual: 16

Unexpected Size for AutoLayoutMaxPacking`1[System.Runtime.Intrinsics.Vector256`1[System.Byte]].
     Expected: 64; Actual: 48
Unexpected Offset for AutoLayoutMaxPacking`1[System.Runtime.Intrinsics.Vector256`1[System.Byte]].Value.
     Expected: 32; Actual: 16

Xunit.Sdk.EqualException: Assert.Equal() Failure: Values differ
Expected: 100
Actual:   0
   at Xunit.Assert.Equal[T](T expected, T actual, IEqualityComparer`1 comparer) in /_/src/Microsoft.DotNet.XUnitAssert/src/EqualityAsserts.cs:line 168
   at Xunit.Assert.Equal[T](T expected, T actual) in /_/src/Microsoft.DotNet.XUnitAssert/src/EqualityAsserts.cs:line 90
   at Program.<<Main>$>g__TestExecutor2|25_3(StreamWriter tempLogSw, StreamWriter statsCsvSw, <>c__DisplayClass25_0&) in /home/xuliangyu/runtime/artifacts/tests/coreclr/obj/linux.loongarch64.Debug/Managed/Interop/Interop/generated/XUnitWrapperGenerator/XUnitWrapperGenerator.XUnitWrapperGenerator/FullRunner.g.cs:line 346
14:57:04.429 Failed test: global::Program.TestEntryPoint()
...
...

@LuckyXu-HF
Copy link
Contributor Author

Hi @jkotas , could you please review this PR? Thanks.

@jkotas jkotas merged commit 5091cc1 into dotnet:main Jun 6, 2024
69 checks passed
@LuckyXu-HF LuckyXu-HF deleted the main-LA64-1 branch June 7, 2024 01:02
@github-actions github-actions bot locked and limited conversation to collaborators Jul 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
arch-loongarch64 area-Interop-coreclr community-contribution Indicates that the PR has been added by a community member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants