Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update IHttpClientLogger.cs and IHttpClientAsyncLogger.cs remarks #109618

Merged
merged 3 commits into from
Nov 11, 2024
Merged

Update IHttpClientLogger.cs and IHttpClientAsyncLogger.cs remarks #109618

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
077735c
Update IHttpClientLogger.cs remarks
danespinosa Nov 7, 2024
5e9ced7
Update IHttpClientAsyncLogger.cs
danespinosa Nov 7, 2024
87902e3
Merge branch 'main' into danespinosa-ihttpclientloggerdoc
CarnaViire Nov 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/libraries/Microsoft.Extensions.Http/src/Logging/IHttpClientLogger.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ namespace Microsoft.Extensions.Http.Logging
/// </summary>
/// <remarks>
/// <para>
/// It is up to the user implementing the interface to decide where (to <see cref="Microsoft.Extensions.Logging.ILogger"/>, or anything else) and what exactly to log.
/// It is up to the user implementing the interface to decide whether to use <see cref="Microsoft.Extensions.Logging.ILogger"/>, or anything else, and what exactly to log.
/// However, the implementation should be mindful about potential adverse side effects of accessing some of the <see cref="HttpRequestMessage"/> or
/// <see cref="HttpResponseMessage"/> properties, such as reading from a content stream; if possible, such behavior should be avoided.
/// </para>
Expand Down
Loading