Fix for XSLT extension methods format-date & format-time #114200
Conversation
…erDataAttribute".
…arate folder and namespace.
…onments to separate files.
…rs.XsdDateTimeParser" to "System.Xml.Schema.DateAndTime.Converters.DateAndTimeConverter" and change it type from struct to static class.
…DateTimeFlags" to separated file and matched namespace.
…fications.XsdDateTimeFlags" to "System.Xml.Schema.DateAndTime.Specifications.XsdDateAndTimeFlags" and linked refactoring.
dotnet-policy-service
bot
added
the
community-contribution
|
Tagging subscribers to this area: @dotnet/area-system-xml |
|
@dotnet/area-system-xml , pay attention, please, that current main brunch of .NET Runtime contains some invalid test cases, which was fixed by c6003c7 |
|
Generally, unrelated changes should not be mixed in the same PR (i.e. refactors and bugfixing) according to the PR guide. |
Thanks @lilinus, but I think you're not quite right. Most of my refactoring linked with files, which should be touched for fix current bug. May be only tests can be untouched and XsdDateTime with XsdDuration can be left in the previous folder and namespace, but I still think, that this changes make current code a little more readable. |
|
@jeffhandley , can you review curent pr, please? |
This is fix for #93189 .
I create it as draft, because does not sure that everythink work fine