-
Notifications
You must be signed in to change notification settings - Fork 5.1k
Update global.json #117460
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Update global.json #117460
Conversation
Use the new paths feature and allow newer SDKs when building https://learn.microsoft.com/en-us/dotnet/core/tools/global-json#paths
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR enhances the global.json for SDK lookup flexibility by introducing the new paths
feature, allowing SDK roll-forward on major versions, and providing a custom error message when the required SDK is missing.
- Added
"paths"
array to include local.dotnet
folder and$host$
placeholder. - Kept
"rollForward": "major"
to permit newer SDKs. - Included
"errorMessage"
to guide developers to the install script.
Tagging subscribers to this area: @dotnet/runtime-infrastructure |
Can we remove the dotnet.cmd/sh helper when 10.0 releases and the feature is GA? |
Yes, when VS supports it fully :) |
Note: won’t help for runtime execution. It’s an sdk only feature. We might want to keep the scripts around if someone needs to run a tool on the latest |
(Also ‘dnvm restore’ will just install the sdk locally so you don’t have to worry about this). |
Right but I would still want to replace these scripts eventually with the eng/common/dotnet.cmd/sh scripts that we now have. |
The WasmBuildTests failures are related |
Use the new paths feature and allow newer SDKs when building
https://learn.microsoft.com/en-us/dotnet/core/tools/global-json#paths