Skip to content

[EventPipe] Remove thread lock and cleanup ThreadSessionState lifecycle #118415

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mdh1418 merged 24 commits into from
Jan 21, 2026
Merged

[EventPipe] Remove thread lock and cleanup ThreadSessionState lifecycle #118415

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
24 commits
Select commit Hold shift + click to select a range
9269b35
Remove the EventPipe thread lock
noahfalk Jul 27, 2025
9c2b736
[EventPipe] Fix convert_buffer_to_read_only
mdh1418 Jan 2, 2026
ea88c43
[EventPipe] Fixup thread lock removal assertions
mdh1418 Jan 2, 2026
daf7143
Fix inconsistent volatile qualifier
mdh1418 Jan 7, 2026
1fe4ccf
Guard ep_buffer_convert_to_read_only under buffer_manager lock
mdh1418 Jan 2, 2026
cffdfb2
Cleanup unneeded fields
mdh1418 Jan 2, 2026
09a6577
Fix spacing and update comments
mdh1418 Jan 2, 2026
afe42a5
Refactor write_all_buffers_to_file_v4 loop
mdh1418 Jan 2, 2026
eee4607
[EventPipe][BufferManager] Track thread_session_state
mdh1418 Jul 22, 2025
6674546
Store thread in SequencePoint Map
mdh1418 Jan 7, 2026
285e3a3
Revamp thread_session_state cleanup logic
mdh1418 Jan 7, 2026
f5b2893
Add minimal snapshot optimization
mdh1418 Jan 9, 2026
fc31c98
Address feedback
mdh1418 Jan 9, 2026
2f57141
Update more comments
mdh1418 Jan 9, 2026
34061e2
Extend snapshot to all reader thread variations
mdh1418 Jan 12, 2026
ad4ef72
Synchronize thread unregister with session disable
mdh1418 Jan 12, 2026
204616b
Add snapshot threads helper
mdh1418 Jan 13, 2026
8049191
Add context for reader thread signaling
mdh1418 Jan 13, 2026
161a11a
Allow iterating over empty thread snapshots
mdh1418 Jan 13, 2026
c489497
Restrict scope of current_timestamp_boundary
mdh1418 Jan 15, 2026
3633a3a
Keep session alive to signal reading
mdh1418 Jan 15, 2026
104c226
Add more clarifying comments
mdh1418 Jan 16, 2026
ae22bf0
Address feedback
mdh1418 Jan 20, 2026
34a0b6e
Rename ep_session_suspend_write_event and clarify comments
mdh1418 Jan 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Loading