Skip to content

Conversation

@pavelsavara
Copy link
Member

@pavelsavara pavelsavara commented Sep 23, 2025

  • upgrade npm dependencies

@pavelsavara pavelsavara added this to the 11.0.0 milestone Sep 23, 2025
@pavelsavara pavelsavara requested a review from maraf September 23, 2025 14:29
@pavelsavara pavelsavara self-assigned this Sep 23, 2025
@pavelsavara pavelsavara added arch-wasm WebAssembly architecture area-Build-mono os-browser Browser variant of arch-wasm labels Sep 23, 2025
@pavelsavara
Copy link
Member Author

pavelsavara commented Sep 23, 2025

@maraf @lewing do we want to do (partial) backport to Net10 ?

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR upgrades npm dependencies for the browser runtime component, updating various development and production dependencies to their latest versions. The upgrade also addresses TypeScript/ESLint compatibility issues that arose from the dependency updates.

  • Updated multiple npm packages including TypeScript, ESLint, Rollup, and various plugins
  • Added type cast annotations to resolve TypeScript compilation errors
  • Added ESLint disable comments for duplicate enum values to maintain backward compatibility

Reviewed Changes

Copilot reviewed 9 out of 11 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
src/mono/browser/runtime/package.json Updated npm dependencies and added cross-spawn override
src/mono/browser/runtime/marshal.ts Added ESLint disable comment for duplicate enum values
src/mono/browser/runtime/jiterpreter.ts Added type cast and removed unnecessary semicolon
src/mono/browser/runtime/jiterpreter-support.ts Removed unnecessary semicolon in empty catch block
src/mono/browser/runtime/jiterpreter-jit-call.ts Added type cast and removed unnecessary semicolon
src/mono/browser/runtime/jiterpreter-interp-entry.ts Added type cast and removed unnecessary semicolon
src/mono/browser/runtime/interp-pgo.ts Updated parameter type annotation
src/mono/browser/runtime/diagnostics/common.ts Added type cast for Blob constructor
src/mono/browser/runtime/diagnostics/client-commands.ts Added ESLint disable comment for duplicate enum values

@pavelsavara pavelsavara force-pushed the browser_npm_dependencies branch from 59e637b to 0a828bc Compare September 25, 2025 06:41
@pavelsavara pavelsavara enabled auto-merge (squash) September 25, 2025 10:38
@pavelsavara pavelsavara merged commit 2c3b2a6 into dotnet:main Sep 25, 2025
161 checks passed
@pavelsavara pavelsavara deleted the browser_npm_dependencies branch September 25, 2025 10:42
if (!func.blob)
func.blob = this.endFunction(false);
} catch {
// eslint-disable-next-line @typescript-eslint/no-extra-semi
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the eslint comment still relevant?

@github-actions github-actions bot locked and limited conversation to collaborators Oct 26, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

arch-wasm WebAssembly architecture area-Build-mono os-browser Browser variant of arch-wasm

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants