Revert unhandled exception logic to prevent multiple calls. #120069
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts the behavior to .NET Framework - there is now nothing to prevent the handlers from being called multiple times.
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR reverts the unhandled exception logic in .NET to match .NET Framework behavior by removing safeguards that prevented multiple calls to unhandled exception handlers. The change removes thread-based protection that was preventing handlers from being called multiple times when unhandled exceptions occur.
Key changes:
- Removed thread ID tracking logic that prevented multiple unhandled exception handler calls
- Simplified the
OnUnhandledExceptionmethod by removing concurrency control - Updated test cleanup code to remove references to the removed static field
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/libraries/System.Private.CoreLib/src/System/AppContext.cs | Removed thread ID tracking and protection logic from OnUnhandledException method |
| src/tests/baseservices/exceptions/RaiseAppDomainUnhandledExceptionEvent/RaiseEvent.cs | Removed test cleanup code and UnsafeAccessor usage for the removed static field |
Member
Author
|
This needs to be ported to .NET 10. |
janvorli
approved these changes
Sep 24, 2025
Member
Author
|
/backport to release/10.0-rc2 |
Contributor
|
Started backporting to release/10.0-rc2: https://github.com/dotnet/runtime/actions/runs/17996189425 |
4 tasks
Member
|
/backport to release/10.0 |
Contributor
|
Started backporting to release/10.0: https://github.com/dotnet/runtime/actions/runs/18015789538 |
4 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts the behavior to .NET Framework - there is now nothing to prevent the handlers from being called
multiple times.
Fixes #119968
Fixes #119731
Replaces #119734
/cc @janvorli