Skip to content

Conversation

@janvorli
Copy link
Member

@janvorli janvorli commented Nov 6, 2025

Disable one part of the aliasing_retbuf that uses pinvoke with marshalling, fix disabling of calli_excep test that needs to be disabled on the project level as it is executed as isolated and finally Test_HndIndex_10_Reordered that has the same issue as previously disabled Test_HndIndex_10_Plain.

Disable one part of the aliasing_retbuf that uses pinvoke with
marshalling, fix disabling of calli_excep test that needs to be disabled
on the project level as it is executed as isolated and finally
Test_HndIndex_10_Reordered that has the same issue as previously
disabled Test_HndIndex_10_Plain.
@janvorli janvorli added this to the 11.0.0 milestone Nov 6, 2025
@janvorli janvorli requested review from davidwrighton and kg November 6, 2025 15:32
@janvorli janvorli self-assigned this Nov 6, 2025
Copilot AI review requested due to automatic review settings November 6, 2025 15:32
@dotnet-policy-service
Copy link
Contributor

Tagging subscribers to this area: @BrzVlad, @janvorli, @kg
See info in area-owners.md if you want to be subscribed.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR disables several test cases that are incompatible with the CoreCLR interpreter by adding appropriate skip attributes and conditional checks. The changes address three specific test scenarios: an aliasing_retbuf test that uses pinvoke with marshalling, a calli_excep test requiring native exception interop, and Test_HndIndex_10_Reordered which has similar issues to its plain variant.

  • Adds SkipOnCoreClrAttribute with InterpreterActive mode to IL test files
  • Sets InterpreterIncompatible property at project level for isolated test execution
  • Wraps incompatible code section with runtime check for interpreter

Reviewed Changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.

Show a summary per file
File Description
Test_HndIndex_10_Reordered.il Adds skip attribute to disable test when interpreter is active
Test_HndIndex_10_Plain.il Adds skip attribute to disable test when interpreter is active
calli_excep.ilproj Sets InterpreterIncompatible flag and adds TestLibrary reference
calli_excep.il Adds assembly references for skip attribute and test utilities
aliasing_retbuf.csproj Adds TestLibrary project reference
aliasing_retbuf.cs Wraps incompatible pinvoke code with interpreter runtime check

@davidwrighton
Copy link
Member

Should we have a check for SupportsPInvokeMarshalling instead of the generic interpreter check? You seem to have found a bunch of them.

@janvorli
Copy link
Member Author

janvorli commented Nov 6, 2025

Should we have a check for SupportsPInvokeMarshalling instead of the generic interpreter check? You seem to have found a bunch of them.

This is one of the things covered by the issue that the url in the message for disabling points to. There are about 10 different things that the issue describes as "we won't likely implement them now". I would prefer not breaking it down to individual "SupportsXYZ" yet.

@janvorli janvorli merged commit 177eff3 into dotnet:main Nov 7, 2025
68 of 75 checks passed
@janvorli janvorli deleted the disable-more-tests-for-interpreter branch November 7, 2025 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants