-
Notifications
You must be signed in to change notification settings - Fork 5.2k
Disable more tests for interpreter #121410
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disable more tests for interpreter #121410
Conversation
Disable one part of the aliasing_retbuf that uses pinvoke with marshalling, fix disabling of calli_excep test that needs to be disabled on the project level as it is executed as isolated and finally Test_HndIndex_10_Reordered that has the same issue as previously disabled Test_HndIndex_10_Plain.
|
Tagging subscribers to this area: @BrzVlad, @janvorli, @kg |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR disables several test cases that are incompatible with the CoreCLR interpreter by adding appropriate skip attributes and conditional checks. The changes address three specific test scenarios: an aliasing_retbuf test that uses pinvoke with marshalling, a calli_excep test requiring native exception interop, and Test_HndIndex_10_Reordered which has similar issues to its plain variant.
- Adds
SkipOnCoreClrAttributewithInterpreterActivemode to IL test files - Sets
InterpreterIncompatibleproperty at project level for isolated test execution - Wraps incompatible code section with runtime check for interpreter
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| Test_HndIndex_10_Reordered.il | Adds skip attribute to disable test when interpreter is active |
| Test_HndIndex_10_Plain.il | Adds skip attribute to disable test when interpreter is active |
| calli_excep.ilproj | Sets InterpreterIncompatible flag and adds TestLibrary reference |
| calli_excep.il | Adds assembly references for skip attribute and test utilities |
| aliasing_retbuf.csproj | Adds TestLibrary project reference |
| aliasing_retbuf.cs | Wraps incompatible pinvoke code with interpreter runtime check |
|
Should we have a check for SupportsPInvokeMarshalling instead of the generic interpreter check? You seem to have found a bunch of them. |
This is one of the things covered by the issue that the url in the message for disabling points to. There are about 10 different things that the issue describes as "we won't likely implement them now". I would prefer not breaking it down to individual "SupportsXYZ" yet. |
Disable one part of the aliasing_retbuf that uses pinvoke with marshalling, fix disabling of calli_excep test that needs to be disabled on the project level as it is executed as isolated and finally Test_HndIndex_10_Reordered that has the same issue as previously disabled Test_HndIndex_10_Plain.