Skip to content

Conversation

@vcsjones
Copy link
Member

@vcsjones vcsjones commented Nov 15, 2025

Backport of #121450 to release/9.0-staging

cc @bartonjs

Customer Impact

These are test only changes. These changes react to more environments in CI rejecting certificate chains that use an RSA+SHA-1 root certificate.

  • Customer reported
  • Found internally

Regression

  • Yes
  • No

Testing

Tests that were failing are now passing in CI.

Risk

None, test only changes.

Copilot AI review requested due to automatic review settings November 15, 2025 20:50
@vcsjones vcsjones requested a review from bartonjs November 15, 2025 20:51
@vcsjones vcsjones added this to the 9.0.x milestone Nov 15, 2025
@dotnet-policy-service
Copy link
Contributor

Tagging subscribers to this area: @dotnet/area-system-security, @bartonjs, @vcsjones
See info in area-owners.md if you want to be subscribed.

Copilot finished reviewing on behalf of vcsjones November 15, 2025 20:52
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 5 out of 5 changed files in this pull request and generated 6 comments.

Comments suppressed due to low confidence (1)

src/libraries/System.Security.Cryptography/tests/X509Certificates/ChainTests.cs:485

  • [nitpick] The new assertion logic with Assert.Fail provides better diagnostics when chain validation doesn't match expectations. However, there's a potential inconsistency: the failure message uses single quotes around boolean values ('true', 'false') but uses single quotes around the chain flags string as well. Consider using consistent formatting, such as using backticks for code values or removing quotes from boolean values for consistency with typical C# boolean representations.
                chain.ChainPolicy.ExtraStore.Add(microsoftDotComRoot);

                // Ignore anything except NotTimeValid
                chain.ChainPolicy.VerificationFlags = X509VerificationFlags.AllFlags & ~X509VerificationFlags.IgnoreNotTimeValid;

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants