Assume hash handles are always reusable in HashProviderCng. #122813
+8
−33
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HashProviderCng was previously accounting for Windows 7 not supporting BCRYPT_HASH_REUSABLE_FLAG. We can assume this flag is always supported now that Windows 7 is not supported anymore.
Contributor
|
Tagging subscribers to this area: @dotnet/area-system-security, @bartonjs, @vcsjones |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR removes Windows 7 compatibility code from HashProviderCng by assuming that the BCRYPT_HASH_REUSABLE_FLAG is always supported, simplifying the implementation now that Windows 7 support has been dropped.
Key changes:
- Removed the
_reusablefield and all conditional logic that handled non-reusable hash scenarios - Simplified the constructor to always create reusable hash handles without fallback logic
- Streamlined the
Reset()method to always use the reusable flag
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
HashProviderCng was previously accounting for Windows 7 not supporting BCRYPT_HASH_REUSABLE_FLAG. We can assume this flag is always supported now that Windows 7 is not supported anymore.
Contributes to #71075.