[browser][mono] Resolve LibraryImport via dlopen/dlsym for WASM side modules (#123570) #123571
+20
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
needs-area-label
dotnet-policy-service
bot
added
the
community-contribution
denis-kudelin
force-pushed
the
wasm-dylink-pinvoke
branch
from
601c1c7 to
3792bbc
Compare
Author
@dotnet-policy-service agree |
denis-kudelin
force-pushed
the
wasm-dylink-pinvoke
branch
from
3792bbc to
5b3df3e
Compare
jkotas
added
area-Interop-mono
arch-wasm
denis-kudelin
force-pushed
the
wasm-dylink-pinvoke
branch
9 times, most recently
from
1d85720 to
c1e7b21
Compare
denis-kudelin
changed the title
…t#123570) Signed-off-by: Denis Kudelin <[email protected]>
denis-kudelin
force-pushed
the
wasm-dylink-pinvoke
branch
from
c1e7b21 to
19653bc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #123570
Summary
Enable LibraryImport to resolve symbols from Emscripten side modules by falling back to dlopen/dlsym after the pinvoke table check, and surface meaningful managed errors on failure.
Motivation
In browser-wasm with MAIN_MODULE/SIDE_MODULE, LibraryImport names are not in the generated pinvoke table. Without a dlopen/dlsym fallback, side modules cannot be resolved even when present.
Changes