[mono][interp] Expand compare + brfalse/brtrue with single conditional branch opcode #80046
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tagging subscribers to this area: @BrzVlad Issue DetailsThis PR expands
|
kotlarmilos
changed the title
Closed
|
Failure is #79874 |
BrzVlad
reviewed
Jan 3, 2023
| @@ -9823,20 +9823,42 @@ interp_super_instructions (TransformData *td) | |||
| gboolean negate = opcode == MINT_BRFALSE_I4; | |||
| int cond_sreg = ins->sregs [0]; | |||
| InterpInst *def = td->locals [cond_sreg].def; | |||
| if (def != NULL) { | |||
| if (def != NULL && td->local_ref_count [cond_sreg] == 1) { | |||
There was a problem hiding this comment.
you could use local_ref_count directly as below
BrzVlad
approved these changes
Jan 3, 2023
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR expands
compare + brfalse/brtruewith single conditional branch opcode.