Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release/8.0-preview1] Branding of .NET 8.0 Preview1 #81398

Merged

Conversation

carlossanlop
Copy link
Member

Changing alpha to preview, like we did for .NET 7.0 Preview1: #64123

@ghost
Copy link

ghost commented Jan 31, 2023

Tagging subscribers to this area: @dotnet/runtime-infrastructure
See info in area-owners.md if you want to be subscribed.

Issue Details

Changing alpha to preview, like we did for .NET 7.0 Preview1: #64123

Author: carlossanlop
Assignees: carlossanlop
Labels:

area-Infrastructure

Milestone: 8.0.0

@carlossanlop carlossanlop changed the title Branding of .NET 8.0 Preview1 [release/8.0-preview1] Branding of .NET 8.0 Preview1 Jan 31, 2023
@carlossanlop
Copy link
Member Author

@radical @lewing @akoeplinger @steveisok are the emscripten failures related to the branding?

@akoeplinger
Copy link
Member

akoeplinger commented Jan 31, 2023

Yes it's related:

eng\testing\workloads-testing.targets(226,5): error : (NETCORE_ENGINEERING_TELEMETRY=Build) Could not restore Microsoft.NET.Workload.Emscripten.Current.Manifest-8.0.100-preview.1/8.0.0-alpha.1.23077.4 (can't find C:\Users\cloudtest\AppData\Local\Temp\workload-s1vkosld.1ds\nuget-cache\microsoft.net.workload.emscripten.current.manifest-8.0.100-preview.1\8.0.0-alpha.1.23077.4)

@radical can you please take a look?

@carlossanlop
Copy link
Member Author

carlossanlop commented Jan 31, 2023

@lewing @radical there's a new browser error. Related?

Unhandled exception: Microsoft.NET.Sdk.WorkloadManifestReader.WorkloadManifestCompositionException:
Could not find workload 'microsoft-net-runtime-android' extended by workload
'android' in manifest 'microsoft.net.sdk.android'
[/__w/1/s/artifacts/bin/dotnet-latest/sdk-manifests/7.0.100/microsoft.net.sdk.android/WorkloadManifest.json]

@lewing
Copy link
Member

lewing commented Jan 31, 2023

there is currently a chicken and egg problem with the feature banding of the workloads when installer branding in main is behind runtime, this should resolve once the latest dotnet/installer build finishes. we'll add this to the list of issues with the feature banding logic.

the current installer is alpha.1 so it doesn't look into the preview.1 feature band so workload tests are finding the alpha.1 workload packs that came with installer not the newly built ones.

@carlossanlop carlossanlop merged commit 1b2c4a9 into dotnet:release/8.0-preview1 Feb 1, 2023
@carlossanlop carlossanlop deleted the BrandingNet8Preview1 branch February 1, 2023 02:23
@ghost ghost locked as resolved and limited conversation to collaborators Mar 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants