[release/8.0-preview1] Install workload manifests in sdk band version derived from the #81457
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
.. installer version. - This is only for running Wasm.Build.Tests Two new properties are added: - `SdkBandVersionForWorkload_ComputedFromInstaller`: this is based on the version derived from `dotnet --version`. `8.0.0-alpha.1.1234.1` becomes `8.0.0-alpha.1`, and is used as the path where the manifests get installed for testing: `sdk-manifests/$(SdkBandVersionForWorkload_ComputedFromInstaller)` - `SdkBandVersionForWorkload_FromRuntimeVersions`: this is the version band used for the packages generated. And simply rename of the earlier `$(SdkBandVersionForWorkload)`.
|
Tagging subscribers to this area: @directhex Issue Details.. installer version.
Two new properties are added:
|
lewing
approved these changes
Feb 1, 2023
radical
changed the title
|
will be required when dotnet/sdk#30244 makes it through installer |
|
CI failures are unrelated: |
steveisok
approved these changes
Feb 1, 2023
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
.. installer version.
Two new properties are added:
SdkBandVersionForWorkload_ComputedFromInstaller: this is based on theversion derived from
dotnet --version.8.0.0-alpha.1.1234.1becomes8.0.0-alpha.1, and is used as the path where the manifests get installed for testing:sdk-manifests/$(SdkBandVersionForWorkload_ComputedFromInstaller)SdkBandVersionForWorkload_FromRuntimeVersions: this is the versionband used for the packages generated. And simply rename of the earlier
$(SdkBandVersionForWorkload).