Add osx-arm64 to official RIDs in ILCompiler NuGet #82558
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
community-contribution
|
Tagging subscribers to this area: @agocke, @MichalStrehovsky, @jkotas Issue DetailsContributes to #82542 When cross-compiling from osx-x64 to osx-arm64 the target runtime package was not restored correctly. This can be explicitly fixed in the SDK. However, the reason why the opposite (osx-arm64 -> osx-x64) works is because the Microsoft.DotNet.ILCompiler dependency pulls the correct runtime package. The osx-arm64 dependency was missing though, and thus the runtime package was never restored.
|
|
Neat fix! 👍 |
agocke
approved these changes
Feb 23, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributes to #82542
When cross-compiling from osx-x64 to osx-arm64 the target runtime package was not restored correctly. This can be explicitly fixed in the SDK. However, the reason why the opposite (osx-arm64 -> osx-x64) works is because the Microsoft.DotNet.ILCompiler dependency pulls the correct runtime package. The osx-arm64 dependency was missing though, and thus the runtime package was never restored.
More details