Stop storing the parsed RID fallback graph#82811
Merged
elinor-fung merged 2 commits intodotnet:mainfrom Mar 2, 2023
Merged
Conversation
ghost
assigned
|
Tagging subscribers to this area: @vitek-karas, @agocke, @VSadov Issue DetailsAfter startup, we only need the RID fallback graph from the root framework for component dependency resolution ( Removing this stored value also lines up with the plan to move to algorithmic RID fallback rather than reading from the .deps.json.
|
vitek-karas
reviewed
Mar 1, 2023
This was referenced Mar 2, 2023
vitek-karas
approved these changes
Mar 2, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After startup, we only need the RID fallback graph from the root framework for component dependency resolution (
AssemblyDependencyResolver). This change stops storing that graph (which is decently large for portable linux) for all applications and switches to re-populating it on demand.Removing this stored value also lines up with the plan to move to algorithmic RID selection rather than reading from the .deps.json.