Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[mono] Update runtimeFlavor property for Mono AOT perf jobs #90215

Merged
merged 1 commit into from
Aug 10, 2023

Conversation

kotlarmilos
Copy link
Member

@kotlarmilos kotlarmilos commented Aug 9, 2023

This PR updates the runtimeFlavor property for Mono AOT performance jobs.

@kotlarmilos kotlarmilos added this to the 8.0.0 milestone Aug 9, 2023
@kotlarmilos kotlarmilos self-assigned this Aug 9, 2023
@ghost
Copy link

ghost commented Aug 9, 2023

Tagging subscribers to this area: @directhex
See info in area-owners.md if you want to be subscribed.

Issue Details

This PR sets the runtimeFlavor property for Mono AOT performance jobs.

Author: kotlarmilos
Assignees: kotlarmilos
Labels:

area-Infrastructure-mono

Milestone: 8.0.0

@lewing
Copy link
Member

lewing commented Aug 9, 2023

[10:30:30] info: [2023-08-09T10:30:30.638Z] [FAIL] System.Net.WebSockets.Client.Tests.InvokerCloseTest.CloseOutputAsync_ClientInitiated_CanReceive_CanClose(server: ws://127.0.0.1:49166/WebSocket/EchoWebSocket.ashx)
[10:30:30] info: Assert.Equal() Failure
[10:30:30] info: Expected: 17
[10:30:30] info: Actual:   0
[10:30:30] info:    at System.Net.WebSockets.Client.Tests.CloseTest.CloseOutputAsync_ClientInitiated_CanReceive_CanClose(Uri server)
[10:30:30] info: --- End of stack trace from previous location ---
[10:30:30] info: [2023-08-09T10:30:30.639Z] [STRT] System.Net.WebSockets.Client.Tests.InvokerCloseTest.CloseOutputAsync_ClientInitiated_CanReceive_CanClose(server: wss://127.0.0.1:49168/WebSocket/EchoWebSocket.ashx)

@pavelsavara
Copy link
Member

InvokerCloseTest.CloseOutputAsync_ClientInitiated_CanReceive_CanClose

Could be just fragile test, let's re-run

@pavelsavara
Copy link
Member

I created #90257 to see if that happens more often

@kotlarmilos
Copy link
Member Author

The failure doesn't look related to the changes in this PR, could be a transient issue.

@kotlarmilos kotlarmilos merged commit df5f3e6 into dotnet:main Aug 10, 2023
117 checks passed
kotlarmilos added a commit that referenced this pull request Aug 14, 2023
LoopedBard3 pushed a commit that referenced this pull request Aug 14, 2023
@ghost ghost locked as resolved and limited conversation to collaborators Sep 9, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants