Fix the Syndication Feed RFC822 DateTimeParser #99194
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RFC822 allows single-digit date values and two-digit year values in the publication date (pubDate). The existing date-time parser only accepted two-digit dates and (for some formats) four-digit years.
ghost
added
the
filipnavara
reviewed
Mar 2, 2024
| "d MMMM yyyy HH:mm:ss zzz", | ||
| "ddd, d MMM yyyy HH:mm:ss zzz", | ||
| "d MMM yyyy HH:mm:ss zzz", | ||
|
|
filipnavara
reviewed
Mar 2, 2024
...raries/System.ServiceModel.Syndication/src/System/ServiceModel/Syndication/DateTimeHelper.cs
Show resolved
Hide resolved
|
Any chance on getting this merged for .NET 9? |
|
Any chance of getting this merged for 9.0.2? This is very simple fix for a bug caused by a small typo. There is almost zero risk to merging this, and it would fix a bug that has existed in my application for a year now. |
There was a problem hiding this comment.
Pull Request Overview
This PR updates the date-time format patterns in the RFC822 parser to correctly handle single-digit day values and two-digit year values as per the RFC822 specification.
- Updated date format strings to use "d" instead of "dd" for days.
- Adjusted both the time formats with seconds and without seconds to support the new behavior.
Comments suppressed due to low confidence (2)
src/libraries/System.ServiceModel.Syndication/src/System/ServiceModel/Syndication/DateTimeHelper.cs:95
- Ensure that unit tests cover the new date-time formats, particularly for cases with single-digit day values and two-digit years.
"ddd, d MMMM yyyy HH:mm:ss zzz",
src/libraries/System.ServiceModel.Syndication/src/System/ServiceModel/Syndication/DateTimeHelper.cs:105
- [nitpick] Consider reviewing the ordering of the format patterns to ensure that the most frequently encountered date formats are prioritized for optimal performance.
// The original RFC822 spec listed 2 digit years. RFC1123 updated the format to include 4 digit years and states that you should use 4 digits.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RFC822 allows single-digit date values and two-digit year values in the publication date (
pubDate). The existingRfc822DateTimeParsermethod inSystem.ServiceModel.Syndication.DateTimeHelperonly accepts two-digit dates and (for some formats) four-digit years.This PR updates the list of date-time formats.
Fixes #99193