Adjust the samples code so that it matches the refactored tutorial#7067
Merged
BillWagner merged 2 commits intodotnet:mainfrom Sep 3, 2025
Merged
Conversation
BillWagner
approved these changes
Sep 2, 2025
Member
BillWagner
left a comment
BillWagner
left a comment
There was a problem hiding this comment.
Thanks @BartoszKlonowski
I had one optional comment. I'll merge after we finish dotnet/docs#48202
| <PropertyGroup> | ||
| <OutputType>Exe</OutputType> | ||
| <TargetFramework>net6.0</TargetFramework> | ||
| <TargetFramework>net8.0</TargetFramework> |
Member
There was a problem hiding this comment.
Feel free to use .NET 9 instead of 8.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request is the follow-up to the dotnet/docs#48202 PR that makes the project now use
GetFromJsonAsyncinstead ofDeserializeAsync.To keep the code up-to-date this PR also makes sure that the new version of .NET is used instead of old v6.
For more info please check the mentioned PR to docs repository.