Parse SdkFeatureBand from .version file#38802
Merged
baronfel merged 1 commit intodotnet:mainfrom Feb 15, 2024
Merged
Conversation
ghost
added
baronfel
force-pushed
the
read-featureband-from-versions-txt
branch
from
844d840 to
8e02a3e
Compare
Member
Author
|
@joeloff here's the matching parsing side of the Installer PR. |
baronfel
commented
Feb 15, 2024
Comment on lines
+8
to
+27
| public bool Exists { get; init; } | ||
|
|
||
| public string CommitSha { get; set; } | ||
| public string CommitSha { get; init; } | ||
|
|
||
| public string BuildNumber { get; set; } | ||
| public string BuildNumber { get; init; } | ||
|
|
||
| public string FullNugetVersion { get; init; } | ||
|
|
||
| public string SdkFeatureBand { get; init; } | ||
|
|
||
| /// <summary> | ||
| /// The runtime identifier (rid) that this CLI was built for. | ||
| /// </summary> | ||
| /// <remarks> | ||
| /// This is different than RuntimeInformation.RuntimeIdentifier because the | ||
| /// This is different than RuntimeInformation.RuntimeIdentifier because the | ||
| /// BuildRid is a RID that is guaranteed to exist and works on the current machine. The | ||
| /// RuntimeInformation.RuntimeIdentifier may be for a new version of the OS that | ||
| /// RuntimeInformation.RuntimeIdentifier may be for a new version of the OS that | ||
| /// doesn't have full support yet. | ||
| /// </remarks> | ||
| public string BuildRid { get; set; } | ||
| public string BuildRid { get; init; } |
Member
Author
There was a problem hiding this comment.
I took the opportunity to make these init-only properties while I was here (though this required making the small polyfill for net472).
joeloff
approved these changes
Feb 15, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Companion to dotnet/installer#18687 - this parses the feature band that's now written to that file so that we can use it inside the SDK if required.