Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding SignalR CustomAwaitable feature switch #41832

Merged
merged 1 commit into from
Jul 9, 2024
Merged

Adding SignalR CustomAwaitable feature switch #41832

merged 1 commit into from
Jul 9, 2024

Conversation

eerhardt
Copy link
Member

This is the SDK portion of changes needed to make SignalR compatible with native AOT. See dotnet/aspnetcore#56460.

@eerhardt
Adding SignalR CustomAwaitable feature switch
ec2ed67 
This is the SDK portion of changes needed to make SignalR compatible with native AOT. See dotnet/aspnetcore#56460.
@eerhardt eerhardt requested a review from vijayrkn as a code owner June 27, 2024 20:50
@dotnet-issue-labeler dotnet-issue-labeler bot added the untriaged Request triage from a team member label Jun 27, 2024
@eerhardt eerhardt added Area-AspNetCore RazorSDK, BlazorWebAssemblySDK, dotnet-watch and removed untriaged Request triage from a team member labels Jun 27, 2024
@dotnet-policy-service Dotnet Policy Service
Copy link
Contributor

Thanks for your PR, @eerhardt.
To learn about the PR process and branching schedule of this repo, please take a look at the SDK PR Guide.

@dotnet dotnet deleted a comment from dotnet-issue-labeler bot Jun 27, 2024
@dotnet dotnet deleted a comment from dotnet-issue-labeler bot Jun 27, 2024
@eerhardt eerhardt requested a review from sbomer July 9, 2024 15:12
sbomer
sbomer approved these changes Jul 9, 2024
View reviewed changes
Copy link
Member

@sbomer sbomer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@eerhardt eerhardt merged commit f7472c8 into dotnet:main Jul 9, 2024
36 checks passed
@eerhardt eerhardt deleted the AddSignalRFeatureSwitch branch July 9, 2024 22:39
@ellahathaway ellahathaway mentioned this pull request Jul 10, 2024
Merged
@eerhardt eerhardt mentioned this pull request Jul 18, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sbomer sbomer sbomer approved these changes

@BrennanConroy BrennanConroy Awaiting requested review from BrennanConroy

@vijayrkn vijayrkn Awaiting requested review from vijayrkn vijayrkn is a code owner

Assignees
No one assigned
Labels
Area-AspNetCore RazorSDK, BlazorWebAssemblySDK, dotnet-watch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eerhardt @sbomer