Skip to content

Unset CompilerType from Csc#48843

Merged
jjonescz merged 2 commits intodotnet:mainfrom
jjonescz:core-prop
Jun 11, 2025
Merged

Unset CompilerType from Csc#48843
jjonescz merged 2 commits intodotnet:mainfrom
jjonescz:core-prop

Conversation

@jjonescz
Copy link
Member

@jjonescz jjonescz commented May 7, 2025

No description provided.

@jjonescz jjonescz requested a review from jaredpar May 16, 2025 08:48
@jjonescz jjonescz marked this pull request as ready for review May 16, 2025 13:11
Copilot AI review requested due to automatic review settings May 16, 2025 13:11
@jjonescz jjonescz requested a review from a team as a code owner May 16, 2025 13:11
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR removes the CompilerType property from several MSBuild targets to unset the compiler type from Csc.

  • Removed CompilerType from Microsoft.NET.Build.Tasks targets
  • Removed CompilerType from Razor SDK Component targets
  • Removed CompilerType from Razor SDK Compilation targets

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
src/Tasks/Microsoft.NET.Build.Tasks/targets/Microsoft.NET.Sdk.targets Removed CompilerType attribute from the build targets
src/RazorSdk/Targets/Microsoft.NET.Sdk.Razor.Component.targets Removed CompilerType attribute from the Razor component targets
src/RazorSdk/Targets/Microsoft.NET.Sdk.Razor.Compilation.targets Removed CompilerType attribute from the Razor compilation targets
Comments suppressed due to low confidence (3)

src/Tasks/Microsoft.NET.Build.Tasks/targets/Microsoft.NET.Sdk.targets:1237

  • Consider updating the related documentation or release notes to explicitly mention the removal of the CompilerType property, ensuring that users understand this change.
CompilerType="$(RoslynCompilerType)"

src/RazorSdk/Targets/Microsoft.NET.Sdk.Razor.Component.targets:197

  • Ensure that any documentation or internal comments referencing CompilerType in Razor component targets are updated to reflect its removal.
CompilerType="$(RoslynCompilerType)"

src/RazorSdk/Targets/Microsoft.NET.Sdk.Razor.Compilation.targets:131

  • Verify that the removal of CompilerType in the Razor compilation targets is properly communicated through updated documentation or release notes.
CompilerType="$(RoslynCompilerType)"

@marcpopMSFT marcpopMSFT added the Area-AspNetCore RazorSDK, BlazorWebAssemblySDK, StaticWebAssetsSDK label May 27, 2025
@dotnet-policy-service
Copy link
Contributor

Thanks for your PR, @@jjonescz.
To learn about the PR process and branching schedule of this repo, please take a look at the SDK PR Guide.

@jjonescz
Copy link
Member Author

@jaredpar PTAL

@jjonescz jjonescz merged commit 8eb971c into dotnet:main Jun 11, 2025
31 checks passed
@jjonescz jjonescz deleted the core-prop branch June 11, 2025 08:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Area-AspNetCore RazorSDK, BlazorWebAssemblySDK, StaticWebAssetsSDK

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants