Skip to content

Slnx should now be found when using the DotnetSlnPostAction #48879

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 4 commits into
base: release/9.0.3xx
Choose a base branch
from
Open

Slnx should now be found when using the DotnetSlnPostAction #48879

wants to merge 4 commits into from
+57 −27

Conversation

nobowned
Copy link

@nobowned nobowned commented May 8, 2025

@nobowned nobowned requested a review from a team as a code owner May 8, 2025 23:17
@nobowned
Copy link
Author

nobowned commented May 8, 2025

@dotnet-policy-service agree company="Verisk"

edvilme
edvilme requested changes May 9, 2025
View reviewed changes
Copy link
Member

@edvilme edvilme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much for taking this. It looks good overall, but my main concern would mostly be adding the slnx files to the tests, and some nit comments

@build-analysis build-analysis bot mentioned this pull request May 10, 2025
Open
@nobowned nobowned mentioned this pull request May 13, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edvilme edvilme edvilme requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nobowned @edvilme