Slnx should now be found when using the DotnetSlnPostAction#48879
Slnx should now be found when using the DotnetSlnPostAction#48879nobowned wants to merge 5 commits intodotnet:release/9.0.3xxfrom
Conversation
|
@dotnet-policy-service agree company="Verisk" |
edvilme
left a comment
edvilme
left a comment
There was a problem hiding this comment.
Thank you very much for taking this. It looks good overall, but my main concern would mostly be adding the slnx files to the tests, and some nit comments
src/Cli/dotnet/commands/dotnet-new/PostActions/DotnetSlnPostActionProcessor.cs
Outdated
Show resolved
Hide resolved
This reverts commit e7e7827.
|
The tests should pass once dotnet/templating#9011 is merged |
|
We're encountering the same issue where projects created from custom .NET templates aren't being added to the .slnx file. This PR looks like it would solve the problem—do you have an estimated timeline for when it might be merged? |
marcpopMSFT
changed the base branch from
release/9.0.3xx
to
release/10.0.3xx
marcpopMSFT
changed the base branch from
release/10.0.3xx
to
release/9.0.3xx
|
Triage: Looks like we fixed the original issue sometime last summer and it should be resolved in 10.0.1xx. Sorry we missed this PR at the time. We looked at pulling your commit into 10.0.3xx but there are too many merge conflicts at this time. Thank you for your contribution and hopefully the fix we made is sufficient for 10.0.1xx. |
Nice, so the linked templating issue should also be closed as completed? |
6 participants
Fixes #48878 and dotnet/templating#8906