-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Fix 18 misspellings of 'instatiate' to 'instantiate' #49239
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Co-authored-by: nagilson <[email protected]>
Co-authored-by: nagilson <[email protected]>
@copilot Looks like this change caused the |
The changes I made only fixed spelling in error messages ("instatiate" → "instantiate"), not in help text used for completions. The completion script already contains the correct spelling "instantiating". Could you share the specific error message from the failing test? The failure might be due to a test environment issue rather than the spelling corrections, since the completion text I can generate matches the existing snapshot. If the test needs to be updated to reflect corrected error messages, you can usually update the snapshot by running the test with verification update flags (specific approach depends on your test framework). Warning Firewall rules blocked me from connecting to one or more addressesI tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
@copilot Here's the exact error log output for the test. Maybe updating the
|
Co-authored-by: MiYanni <[email protected]>
Head branch was pushed to by a user without write access
You're absolutely right! The test failure was due to the completion system now generating proper completion labels ( I've updated the zsh snapshot file to match the new completion output in commit 9251e2e. The test should now pass with the improved completion labels. Warning Firewall rules blocked me from connecting to one or more addressesI tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
This PR fixes all 18 instances of the misspelling "instatiate" to the correct spelling "instantiate" throughout the repository.
Changes Made
Fixed misspellings in the following files:
Source Files (5 changes):
src/Cli/Microsoft.TemplateEngine.Cli/LocalizableStrings.resx
- Main localization resource filesrc/Cli/Microsoft.TemplateEngine.Cli/LocalizableStrings.Designer.cs
- Generated designer filetest/dotnet-new.IntegrationTests/MSBuildEvaluationTests.cs
- Test assertions (2 occurrences)test/dotnet-new.IntegrationTests/Approvals/DotnetNewInstantiateTests.Constraints_Error_IfTemplateIsRestricted.verified.txt
- Approval test fileLocalization Files (13 changes):
.xlf
files insrc/Cli/Microsoft.TemplateEngine.Cli/xlf/
containing translations for various languagesImpact
All changes are purely cosmetic spelling corrections with no functional impact on the codebase. The error message "Failed to instantiate template" will now be spelled correctly across all languages and test scenarios.
Note on Localization Files
The
.xlf
files were manually updated due to network connectivity issues preventing the normal MSBuild/t:UpdateXlf
target from running during development. In normal circumstances, these would be updated automatically by the build process after modifying the source.resx
file.Fixes #49206.
Warning
Firewall rules blocked me from connecting to one or more addresses
I tried to connect to the following addresses, but was blocked by firewall rules:
c78vsblobprodcus322.vsblob.vsassets.io
/home/REDACTED/work/sdk/sdk/.dotnet/dotnet msbuild /m /nologo /clp:Summary /v:minimal /nr:true /warnaserror /p:TreatWarningsAsErrors=true /p:ContinuousIntegrationBuild=false /home/REDACTED/work/sdk/sdk/artifacts/toolset/restore.proj /t:__WriteToolsetLocation /clp:ErrorsOnly;NoSummary /p:__ToolsetLocationOutputFile=/home/REDACTED/work/sdk/sdk/artifacts/toolset/10.0.0-beta.25265.101.txt
(dns block)dotnet msbuild Microsoft.TemplateEngine.Cli.csproj /t:ResXFileCodeGenerator /v:minimal
(dns block)http://168.63.129.16:80/machine/
/usr/bin/python3 -u bin/WALinuxAgent-2.13.1.1-py3.9.egg -collect-logs
(http block)If you need me to access, download, or install something from one of these locations, you can either:
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.