Utilize a separate pipeline for release tasks #2515
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
need to link official build ci and understand logic from vscode-csharp
Removes the actual publish step to prevent accidentally publishing for now
nagilson
commented
Dec 4, 2025
the 'signed' package is already created and overrides the unsigned one.
default test to true so we dont accidentally ship
MiYanni
approved these changes
Dec 11, 2025
Comment on lines
+4
to
+7
| parameters: | ||
| - name: test | ||
| type: boolean | ||
| default: true |
Member
There was a problem hiding this comment.
nit: For consistency, keep list elements, - {prop}, aligned with the parent property. Thus,
Suggested change
| parameters: | |
| - name: test | |
| type: boolean | |
| default: true | |
| parameters: | |
| - name: test | |
| type: boolean | |
| default: true |
You did this with variables: and repositories: and other stuff below. It still works if it is indented extra, but it just adds to confusion about YAML if they're all not the same.
| steps: | ||
| - template: pipeline-templates/install-node.yaml@self | ||
| - template: pipeline-templates/list-file-structure.yaml@self | ||
| - bash: | |
Member
There was a problem hiding this comment.
bash: is a shorthand for this task: https://learn.microsoft.com/en-us/azure/devops/pipelines/tasks/reference/bash-v3?view=azure-pipelines
Any reason this script needs to be bash on Windows? It then requires the script to run under WSL. Copilot could probably directly convert this to PowerShell pretty easily. Then, this entire job just uses PowerShell.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Succeeds #2411
To migrate to a standardized deployment approach, we'd like to move away from the legacy Azure DevOps release mechanisms. The best way I've seen to do that is to have a separate release pipeline which handles only release activities - the release pipeline must be quite restricted which causes issues even trying to run our security scanners and compliance tools such as SBOM, so trying to create a deployment off our existing pipeline served challenging.
This approach is based off of the vscode-csharp release pipeline. https://github.com/dotnet/vscode-csharp/blob/main/azure-pipelines/release.yml
An example run is here: https://dev.azure.com/dnceng/internal/_build/results?buildId=2858298&view=results
Other updates to make this work:
npm ciinstall of vsce. This is because we are blocked from installing updates in a ci machine so it would fail anytime a package sub dependency got an update (which happens nearly daily)Thank you to @/joerobich who was very helpful in explaining the vscode-csharp-release structure.