Added ThemeGenerator script for Fluent and generated combined Fluent theme resource dictionaries #9422
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-policy-service
bot
added
the
PR
src/Microsoft.DotNet.Wpf/src/PresentationFramework/System/Windows/ThemeManager.cs
Show resolved
Hide resolved
singhashish-wpf
approved these changes
Jul 18, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In this PR, I have added a simple PS script to combine all the Fluent theme XAML files into one. I have also removed some duplicate keys from the XAML files for this.
The ThemeGenerator.Fluent script unlike the previous script does not provide many functionalities ( like optimizing keys, and checking for DynamicResource references ) . It is a very simple script at the moment but depending on the necessities, we will keep adding features to this.
There is a reference to this task in : #8991
Customer Impact
Instead of loading multiple merged ResourceDictionaries, developer will load a single large ResourceDictionary which will help boost performance.
Regression
N/A
Testing
Yet to be done.
Risk
N/A
Microsoft Reviewers: Open in CodeFlow
Microsoft Reviewers: Open in CodeFlow