-
-
Notifications
You must be signed in to change notification settings - Fork 351
fix(FlipClock): should update digit after switch visible #6473
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Reviewer's GuideRefactors FlipClock update logic by removing the stale-value cache and simplifying the digit-refresh loop to always call setDigits for visible units, ensuring correct updates after visibility toggles. Class diagram for FlipClock update logic refactorclassDiagram
class FlipClock {
+updateDigits()
-counter
-totalMilliseconds
-countDown
-getDate()
-getConfig()
-setDigits(list, value, digits, countDown)
}
%% lastValues cache removed
File-Level Changes
Assessment against linked issues
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @ArgoZhang - I've reviewed your changes and they look great!
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6473 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 749 749
Lines 32366 32366
Branches 4573 4573
=========================================
Hits 32366 32366
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Link issues
fixes #6472
Summary By Copilot
Regression?
Risk
Verification
Packaging changes reviewed?
☑️ Self Check before Merge
Summary by Sourcery
Bug Fixes: