Skip to content

fix(FlipClock): should update digit after switch visible #6473

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 23, 2025
Merged

Conversation

ArgoZhang
Copy link
Member

@ArgoZhang ArgoZhang commented Jul 23, 2025

Link issues

fixes #6472

Summary By Copilot

Regression?

  • Yes
  • No

Risk

  • High
  • Medium
  • Low

Verification

  • Manual (required)
  • Automated

Packaging changes reviewed?

  • Yes
  • No
  • N/A

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • Merge the latest code from the main branch

Summary by Sourcery

Bug Fixes:

  • Remove lastValues tracking and unconditional guard to ensure digits are updated on each tick even after visibility changes.

@bb-auto bb-auto bot added the bug Something isn't working label Jul 23, 2025
Copy link
Contributor

sourcery-ai bot commented Jul 23, 2025

Reviewer's Guide

Refactors FlipClock update logic by removing the stale-value cache and simplifying the digit-refresh loop to always call setDigits for visible units, ensuring correct updates after visibility toggles.

Class diagram for FlipClock update logic refactor

classDiagram
    class FlipClock {
        +updateDigits()
        -counter
        -totalMilliseconds
        -countDown
        -getDate()
        -getConfig()
        -setDigits(list, value, digits, countDown)
    }
    %% lastValues cache removed
Loading

File-Level Changes

Change Details Files
Removed lastValues cache and associated checks
  • Deleted initialization of lastValues object
  • Removed conditional comparison of previous and current digit values
  • Eliminated assignments to lastValues after updates
src/BootstrapBlazor/Components/FlipClock/FlipClock.razor.js
Simplified update loop to always refresh digits
  • Added early return for null digit lists
  • Unconditionally invoke setDigits with current date values
src/BootstrapBlazor/Components/FlipClock/FlipClock.razor.js

Assessment against linked issues

Issue Objective Addressed Explanation
#6472 Ensure that the FlipClock component updates its digit display after switching visibility.

Possibly linked issues


Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@bb-auto bb-auto bot added this to the 9.8.0 milestone Jul 23, 2025
@ArgoZhang ArgoZhang merged commit 54342ac into main Jul 23, 2025
5 checks passed
@ArgoZhang ArgoZhang deleted the fix-flip branch July 23, 2025 04:09
Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @ArgoZhang - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Copy link

codecov bot commented Jul 23, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (fc34c3c) to head (0ab3282).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main     #6473   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          749       749           
  Lines        32366     32366           
  Branches      4573      4573           
=========================================
  Hits         32366     32366           
Flag Coverage Δ
BB 100.00% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug(FlipClock): should update digit after switch visible
1 participant