-
-
Notifications
You must be signed in to change notification settings - Fork 351
doc(TcpSocket): update TcpSokcet sample code #6477
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Reviewer's GuideThis PR revises TCP socket sample code to use the new generic data converter API by renaming attributes, types, interfaces, and configuration methods, and adds package usage tips for the BootstrapBlazor.TcpSocket library. Class diagram for configuration API changes in data convertersclassDiagram
class DataConvertersOptions {
+AddTypeConverter<T>()
+AddPropertyConverter<T>(property, DataPropertyConverterAttribute)
}
class IServiceCollection {
+ConfigureDataConverters(Action<DataConvertersOptions> options)
}
IServiceCollection --> DataConvertersOptions : configures
DataConvertersOptions --> DataPropertyConverterAttribute : uses
File-Level Changes
Assessment against linked issues
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @ArgoZhang - I've reviewed your changes and they look great!
Prompt for AI Agents
Please address the comments from this code review:
## Individual Comments
### Comment 1
<location> `src/BootstrapBlazor.Server/Components/Samples/Sockets/DataEntities.razor:66` </location>
<code_context>
</ul>
<p>自定义数据类型转化器示例</p>
- <Pre>[SocketTypeDataConverter(Type = typeof(SocketDataConverter<MockEntity>))]
+ <Pre>[SocketTypeDataConverter(Type = typeof(DataConverter<MockEntity>))]
class MockEntity
{
</code_context>
<issue_to_address>
Check for consistency in attribute naming.
If the difference in naming is intentional, please document the distinction; otherwise, consider using consistent attribute names throughout.
</issue_to_address>
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
src/BootstrapBlazor.Server/Components/Samples/Sockets/DataEntities.razor
Show resolved
Hide resolved
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6477 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 714 714
Lines 31383 31383
Branches 4431 4431
=========================================
Hits 31383 31383
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Link issues
fixes #6476
Summary By Copilot
Regression?
Risk
Verification
Packaging changes reviewed?
☑️ Self Check before Merge
Summary by Sourcery
Update TcpSocket sample documentation to reflect renamed converter API and include missing package tips
Documentation: