feat(FluentSystemIcons): add microsoft fluent free icon set #6483
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reviewer's GuideThis PR integrates the Microsoft Fluent System Icons into BootstrapBlazor by adding a new demo page, localization entries, a menu item, and registering the icon CSS as a static asset in the server project. Class diagram for the new FluentSystemIcons componentclassDiagram
class FluentSystemIcons {
<<partial>>
+FluentSystemIcons()
}
File-Level Changes
Assessment against linked issues
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hey @ArgoZhang - I've reviewed your changes - here's some feedback:
- Remove or rephrase the unprofessional remark in the sample page (e.g., “是我见过设计最糟糕的图标库，太不专业了！！！”) to keep the tone neutral and professional.
- Ensure all Localizer keys used in FluentSystemIcons.razor (Title, BaseUsageText, P1, P2, Icons, etc.) are defined in both en-US.json and zh-CN.json so translations render correctly.
- Fix the icon list labels so each entry matches its file (e.g., Filled, Light, Regular, Resizable) instead of repeating "Filled" for every item.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- Remove or rephrase the unprofessional remark in the sample page (e.g., “是我见过设计最糟糕的图标库，太不专业了！！！”) to keep the tone neutral and professional.
- Ensure all Localizer keys used in FluentSystemIcons.razor (Title, BaseUsageText, P1, P2, Icons, etc.) are defined in both en-US.json and zh-CN.json so translations render correctly.
- Fix the icon list labels so each entry matches its file (e.g., Filled, Light, Regular, Resizable) instead of repeating "Filled" for every item.
## Individual Comments
### Comment 1
<location> `src/BootstrapBlazor.Server/Components/Samples/Icons/FluentSystemIcons.razor:20` </location>
<code_context>
+
+<Pre><link href="_content/BootstrapBlazor.FluentSystemIcon/FluentSystemIcons-Regular.css" rel="stylesheet"></Pre>
+
+<p class="code-label">是我见过设计最糟糕的图标库，太不专业了！！！</p>
+
+<ul class="ul-demo">
</code_context>
<issue_to_address>
The message in this line is highly opinionated and unprofessional.
Please revise or remove the negative statement to ensure the documentation remains neutral and professional.
</issue_to_address>
### Comment 2
<location> `src/BootstrapBlazor.Server/Components/Samples/Icons/FluentSystemIcons.razor:23` </location>
<code_context>
+<p class="code-label">是我见过设计最糟糕的图标库，太不专业了！！！</p>
+
+<ul class="ul-demo">
+ <li>Filled: FluentSystemIcons-Filled.css</li>
+ <li>Filled: FluentSystemIcons-Light.css</li>
+ <li>Filled: FluentSystemIcons-Regular.css</li>
+ <li>Filled: FluentSystemIcons-Resizable.css</li>
+</ul>
+
</code_context>
<issue_to_address>
All list items are labeled 'Filled', which may be inaccurate.
Consider updating the labels to match each file's actual style for clarity.
</issue_to_address>
<suggested_fix>
<<<<<<< SEARCH
<ul class="ul-demo">
<li>Filled: FluentSystemIcons-Filled.css</li>
<li>Filled: FluentSystemIcons-Light.css</li>
<li>Filled: FluentSystemIcons-Regular.css</li>
<li>Filled: FluentSystemIcons-Resizable.css</li>
</ul>
=======
<ul class="ul-demo">
<li>Filled: FluentSystemIcons-Filled.css</li>
<li>Light: FluentSystemIcons-Light.css</li>
<li>Regular: FluentSystemIcons-Regular.css</li>
<li>Resizable: FluentSystemIcons-Resizable.css</li>
</ul>
>>>>>>> REPLACE
</suggested_fix>Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
src/BootstrapBlazor.Server/Components/Samples/Icons/FluentSystemIcons.razor
Outdated
Show resolved
Hide resolved
src/BootstrapBlazor.Server/Components/Samples/Icons/FluentSystemIcons.razor
Outdated
Show resolved
Hide resolved
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6483 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 714 714
Lines 31383 31383
Branches 4431 4431
=========================================
Hits 31383 31383
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link issues
fixes #6482
Summary By Copilot
Regression?
Risk
Verification
Packaging changes reviewed?
☑️ Self Check before Merge