Skip to content

feat(TableToolbarButton): add IsOutline parameter #6486

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 24, 2025
Merged

feat(TableToolbarButton): add IsOutline parameter #6486

merged 2 commits into from
Jul 24, 2025

Conversation

ArgoZhang
Copy link
Member

@ArgoZhang ArgoZhang commented Jul 24, 2025

Link issues

fixes #6478

Summary By Copilot

Regression?

  • Yes
  • No

Risk

  • High
  • Medium
  • Low

Verification

  • Manual (required)
  • Automated

Packaging changes reviewed?

  • Yes
  • No
  • N/A

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • Merge the latest code from the main branch

Summary by Sourcery

Extend TableToolbarButton with new styling and state parameters by adding IsOutline, IsBlock, and IsKeepDisabled properties and adjusting attribute ordering.

New Features:

  • Add IsOutline parameter to TableToolbarButton component to enable outline button styles
  • Expose IsBlock and IsKeepDisabled parameters for toolbar buttons

Enhancements:

  • Reorder IsAsync property alongside other button state attributes in the toolbar rendering

Copy link
Contributor

sourcery-ai bot commented Jul 24, 2025

Reviewer's Guide

Introduces an IsOutline parameter (along with related display flags) to TableToolbarButton by updating the TableToolbar razor template to pass these new properties through to the underlying Button component and aligns the project metadata accordingly.

Class diagram for TableToolbarButton and Button parameter update

classDiagram
    class TableToolbarButton {
        +bool IsOutline
        +bool IsBlock
        +bool IsKeepDisabled
    }
    class Button {
        +bool IsOutline
        +bool IsBlock
        +bool IsKeepDisabled
    }
    TableToolbarButton --|> Button : passes parameters
Loading

File-Level Changes

Change Details Files
Extend toolbar button rendering with new display flags
  • Reordered and moved IsAsync attribute
  • Added IsKeepDisabled attribute
  • Added IsBlock attribute
  • Added IsOutline attribute
src/BootstrapBlazor/Components/Table/TableToolbar.razor
Synchronize project file for the new component flags
  • Updated project configuration in csproj
src/BootstrapBlazor/BootstrapBlazor.csproj

Assessment against linked issues

Issue Objective Addressed Explanation
#6478 Ensure that the IsOutline="true" parameter on TableToolbarButton applies the correct outline style.

Possibly linked issues


Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@bb-auto bb-auto bot added the bug Something isn't working label Jul 24, 2025
@bb-auto bb-auto bot added this to the 9.8.0 milestone Jul 24, 2025
@ArgoZhang ArgoZhang added enhancement New feature or request and removed bug Something isn't working labels Jul 24, 2025
Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @ArgoZhang - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Copy link

codecov bot commented Jul 24, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (967b5ca) to head (f3809df).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main     #6486   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          714       714           
  Lines        31383     31383           
  Branches      4431      4431           
=========================================
  Hits         31383     31383           
Flag Coverage Δ
BB 100.00% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ArgoZhang ArgoZhang merged commit 6b73e28 into main Jul 24, 2025
6 checks passed
@ArgoZhang ArgoZhang deleted the fix-table branch July 24, 2025 04:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug(TableToolbarButton): IsOutline="true" 不起作用
1 participant