-
-
Notifications
You must be signed in to change notification settings - Fork 351
feat(TableToolbarButton): add IsOutline parameter #6486
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Reviewer's GuideIntroduces an IsOutline parameter (along with related display flags) to TableToolbarButton by updating the TableToolbar razor template to pass these new properties through to the underlying Button component and aligns the project metadata accordingly. Class diagram for TableToolbarButton and Button parameter updateclassDiagram
class TableToolbarButton {
+bool IsOutline
+bool IsBlock
+bool IsKeepDisabled
}
class Button {
+bool IsOutline
+bool IsBlock
+bool IsKeepDisabled
}
TableToolbarButton --|> Button : passes parameters
File-Level Changes
Assessment against linked issues
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @ArgoZhang - I've reviewed your changes and they look great!
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6486 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 714 714
Lines 31383 31383
Branches 4431 4431
=========================================
Hits 31383 31383
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Link issues
fixes #6478
Summary By Copilot
Regression?
Risk
Verification
Packaging changes reviewed?
☑️ Self Check before Merge
Summary by Sourcery
Extend TableToolbarButton with new styling and state parameters by adding IsOutline, IsBlock, and IsKeepDisabled properties and adjusting attribute ordering.
New Features:
Enhancements: