Skip to content

feat(Badge): use text-bg-color class #6498

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 27, 2025
Merged

feat(Badge): use text-bg-color class #6498

merged 4 commits into from
Jul 27, 2025

Conversation

ArgoZhang
Copy link
Member

@ArgoZhang ArgoZhang commented Jul 27, 2025

Link issues

fixes #6497

Summary By Copilot

Regression?

  • Yes
  • No

Risk

  • High
  • Medium
  • Low

Verification

  • Manual (required)
  • Automated

Packaging changes reviewed?

  • Yes
  • No
  • N/A

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • Merge the latest code from the main branch

Summary by Sourcery

Replace Badge component’s bg-* classes with Bootstrap’s text-bg-* utilities and update SCSS to apply badge text color accordingly.

Enhancements:

  • Change Badge CSS builder to add text-bg-{Color} classes instead of bg-{Color}
  • Update Badge SCSS to target .text-bg-* classes and enforce badge text color

@bb-auto bb-auto bot added the enhancement New feature or request label Jul 27, 2025
@bb-auto bb-auto bot added this to the 9.8.0 milestone Jul 27, 2025
Copy link
Contributor

sourcery-ai bot commented Jul 27, 2025

Reviewer's Guide

This PR refactors the Badge component styling to use Bootstrap's 'text-bg-' utility classes instead of 'bg-' classes, updating both the SCSS and the class builder logic.

Class diagram for updated Badge component class logic

classDiagram
    class Badge {
        - string? ClassString
    }
    %% Before: ClassString used bg-* classes
    %% After: ClassString uses text-bg-* classes
    Badge : - ClassString => "badge text-bg-{Color} [rounded-pill] [additional attributes]"
Loading

File-Level Changes

Change Details Files
Update Badge SCSS to use text-bg classes and set color property
  • Replaced .bg-secondary/.bg-light selectors with .text-bg-secondary/.text-bg-light
  • Changed custom property assignment to direct color with !important
src/BootstrapBlazor/Components/Badge/Badge.razor.scss
Adjust Badge class builder to emit text-bg classes
  • Changed AddClass call from bg-{Color} to text-bg-{Color}
  • Added conditional flag for text-bg classes
src/BootstrapBlazor/Components/Badge/Badge.razor.cs

Assessment against linked issues

Issue Objective Addressed Explanation
#6497 Update the Badge component to use the text-bg-color class instead of the bg-color class.

Possibly linked issues


Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

sourcery-ai[bot]
sourcery-ai bot previously approved these changes Jul 27, 2025
Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @ArgoZhang - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Copy link

codecov bot commented Jul 27, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (main@b02aca8). Learn more about missing BASE report.
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff            @@
##             main     #6498   +/-   ##
========================================
  Coverage        ?   100.00%           
========================================
  Files           ?       714           
  Lines           ?     31387           
  Branches        ?      4431           
========================================
  Hits            ?     31387           
  Misses          ?         0           
  Partials        ?         0           
Flag Coverage Δ
BB 100.00% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ArgoZhang ArgoZhang merged commit c9269f2 into main Jul 27, 2025
6 checks passed
@ArgoZhang ArgoZhang deleted the refactor-badge branch July 27, 2025 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat(Badge): use text-bg-color class
1 participant