-
-
Notifications
You must be signed in to change notification settings - Fork 351
feat(Badge): use text-bg-color class #6498
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Reviewer's GuideThis PR refactors the Badge component styling to use Bootstrap's 'text-bg-' utility classes instead of 'bg-' classes, updating both the SCSS and the class builder logic. Class diagram for updated Badge component class logicclassDiagram
class Badge {
- string? ClassString
}
%% Before: ClassString used bg-* classes
%% After: ClassString uses text-bg-* classes
Badge : - ClassString => "badge text-bg-{Color} [rounded-pill] [additional attributes]"
File-Level Changes
Assessment against linked issues
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @ArgoZhang - I've reviewed your changes and they look great!
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6498 +/- ##
========================================
Coverage ? 100.00%
========================================
Files ? 714
Lines ? 31387
Branches ? 4431
========================================
Hits ? 31387
Misses ? 0
Partials ? 0
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Link issues
fixes #6497
Summary By Copilot
Regression?
Risk
Verification
Packaging changes reviewed?
☑️ Self Check before Merge
Summary by Sourcery
Replace Badge component’s bg-* classes with Bootstrap’s text-bg-* utilities and update SCSS to apply badge text color accordingly.
Enhancements: