With the 1.1dev main branch after 19th June 2025, overlay specific... #52
Conversation
…yling would be a great improvement IMHO
📝 WalkthroughWalkthroughA new overlay-specific Qt stylesheet, Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant Application
participant Config (Dracula.cfg)
participant Stylesheet (Dracula-overlay.qss)
User->>Application: Start application
Application->>Config: Read configuration parameters
Config-->>Application: Return StyleSheet, OverlayActiveStyleSheet
Application->>Stylesheet: Load Dracula-overlay.qss (if overlay active)
Stylesheet-->>Application: Apply overlay styles
Application-->>User: Display themed overlay UI
✨ Finishing Touches🧪 Generate Unit Tests❌ Error creating Unit Test PR.
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (3)
Dracula/Dracula.cfg (1)
78-80: Validate support for OverlayActiveStyleSheet.
Confirm that the application’s config parser recognizes the newOverlayActiveStyleSheetparameter and appliesDracula-overlay.qsscorrectly. Update any user-facing documentation or preference UIs to expose this new setting.Dracula/overlay/Dracula-overlay.qss (2)
1-5: Remove duplicate comment blocks.
The header comment aboutOverlayTabWidgetselectors is duplicated at lines 1–5 and 59–63. Consolidate to a single block to reduce redundancy.Also applies to: 59-63
36-57: DRY up item styling rules.
SeveralQTreeView::itemblocks underGui--OverlayTabWidgetrepeat the same color and background settings. Consider consolidating these into fewer selectors or using a common parent rule to reduce duplication.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (3)
Dracula/Dracula.cfg(1 hunks)Dracula/overlay/Dracula-overlay.qss(1 hunks)package.xml(1 hunks)
🔇 Additional comments (13)
package.xml (1)
5-5: Confirm version bump consistency.
Ensure the package version update to 0.0.7 is reflected in documentation (e.g., README, changelog) and packaging pipelines to avoid mismatches.Dracula/overlay/Dracula-overlay.qss (12)
14-21: Base widget styling is clear.
TheQFrameandQTabWidget::panerules correctly remove borders and backgrounds for overlay panes.
23-29: Approve transparent view styling.
TheQAbstractItemViewrules set transparent backgrounds and appropriate padding. This aligns with the overlay design.
31-34: Approve title bar and splitter transparency.
TheGui--OverlayTitleBarandGui--OverlaySplitterHandleselectors correctly enforce transparency.
65-73: Shadow effect styling is well defined.
The genericGui--OverlayTabWidgetand the#OverlayBottomoverrides correctly configure shadow properties.Also applies to: 75-83
85-89: Approve pane and property editor styling.
The selectors forPropertyEditorand the subsequentQTabWidget::panepane override are consistent and maintain the visual theme.Also applies to: 91-94
96-99: Approve content frame rounding.
TheQSint--ActionGroup QFrame[class="content"]rule properly applies bottom radius for content panels.
101-111: Approve tab-bar alignment rules.
The padding and alignment for top/bottom and left/right tab bars address layout consistency.
113-115: Approve proxy widget hint styling.
TheGui--OverlayProxyWidgethint color property provides a good contrast for placeholder text.
117-126: Approve tool button border states.
The hover, focus, pressed, and checked border styles forGui--OverlayToolButtoncover all interactive states clearly.Also applies to: 132-141
143-149: Verify tool button assets and object names.
MultipleGui--OverlayToolButtonselectors reference image URLs and object names (e.g.,"OBTN Transparent"). Ensure the image files exist atimages_classic/*and the objectName values match the actual widget names in the application.Also applies to: 151-173
176-184: Validate variable in ComboBox styling.
Theselection-background-color: @ThemeAccentColor2;line uses a variable reference. Confirm that the QSS parser supports@ThemeAccentColor2in this context and falls back gracefully if undefined.
188-195: Approve dock widget list fixes.
The margins, borders, and minimum height settings for lists in the model tab ensure consistent sizing across overlay contexts.
|
Note Unit test generation is an Early Access feature. Expect some limitations and changes as we gather feedback and continue to improve it. Generating unit tests... This may take up to 20 minutes. |
| color: #bebebe; /* same as regular QComboBox color */ | ||
| background-color: #232932; | ||
| selection-color: white; | ||
| selection-background-color: @ThemeAccentColor2; |
There was a problem hiding this comment.
This isn't implemented in Dracula, can you please hardcode the relevant color?
There was a problem hiding this comment.
Actually, all of the non-overlay code (starting at line 176) looks to be duplicated inside Dracula.qss (likely a fork from Behave in the first place). Should be safe to delete; if you test again after that and don't notice anything off I'll merge.
…styling would be a great improvement IMHO
After FreeCAD/FreeCAD@e45cf96 was applied in FreeCAD main, this is the result (note the Shape Sketch at the bottom of the scroll area):
with this PR applied and the user re-applying the updated Dracula Preference Pack:
Note: non-overlay settings are not affected and if needed the overlay file can be slimmed down if required but this is based on Behave-dark-overlay.qss which has been thoroughly tested over many months with the recent fix added for this specific issue.