feat: add alucard #28
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the 📝 WalkthroughWalkthroughA new terminal profile file, Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant Terminal
participant Settings
User->>Terminal: Open Terminal app
User->>Settings: Access Terminal Settings
User->>Settings: Go to Profiles tab
User->>Settings: Click "..." below themes list
User->>Settings: Select "Import"
User->>Settings: Choose theme file (Dracula.terminal or Alucard.terminal)
Settings->>Terminal: Import selected theme
User->>Settings: Set imported theme as Default
✨ Finishing Touches🧪 Generate Unit Tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (2)
INSTALL.md (1)
17-22: Tighten wording & fix minor grammar / accessibility nits.Small tweaks make the steps clearer and future-proof (Ventura renamed “Preferences” to “Settings”).
-1. Open the **Terminal** `>` _Settings_; -2. Go to _Profiles tab_; -3. Click "_..._" below the themes list; -4. Select _Import..._; -5. Choose the `Dracula.terminal` (dark) or `Alucard.terminal` (light) file; -6. Set as _Default_; 💜 +1. Open **Terminal** → **Settings** (or **Preferences** on macOS ≤ 12). +2. Select the **Profiles** tab. +3. Click the “…” button (below the profiles list). +4. Choose **Import...**. +5. Pick either `Dracula.terminal` (dark) or `Alucard.terminal` (light). +6. Click **Default** to make the imported theme the default. 💜Alucard.terminal (1)
430-431: Float precision noise – store profile version as2.07instead of2.0699999999999998.Some parsers round-trip this value back to
2.1.
Trimming to two decimals avoids needless diff churn.- <real>2.0699999999999998</real> + <real>2.07</real>
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
Alucard.terminal(1 hunks)INSTALL.md(1 hunks)
🧰 Additional context used
🪛 LanguageTool
INSTALL.md
[uncategorized] ~18-~18: You might be missing the article “the” here.
Context: ...e Terminal > Settings; 2. Go to Profiles tab; 3. Click "..." below th...
(AI_EN_LECTOR_MISSING_DETERMINER_THE)
🔇 Additional comments (2)
INSTALL.md (1)
13-13: Link switch frommaster.ziptomain.zipis fine – please double-check it resolves.A 404 on the download link would break the manual install path.
Kindly open the URL in a browser (or curl) before merging.Alucard.terminal (1)
421-428: Confirm embedded font licensing.The base64 blob encodes a bundled font (“Mono-Regular”). Ensure the font license permits redistribution in binary form within an open-source repo.
If the font is system-default (e.g., SF Mono) Apple’s license forbids bundling; dropping the<key>Font</key>entry lets Terminal fall back to the user’s default monospaced font.
|
I just had a chance to test this, and it puts ANSI color 0 as white and 15 as black, which is inverted from typical use (which breaks, e.g., Vim colorschemes that don't use |
➕ Adds Alucard (Classic) variant according to specs here.