Default show_only_kubernetes_context to false #325
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`kubernetes_context.sh` is called with positional args as such: ``` kubernetes_context.sh $eks_hide_arn $eks_extract_account $hide_kubernetes_user $show_only_kubernetes_context $show_kubernetes_context_label ``` When `show_only_kubernetes_context` defaults to "", the positional arg $5 for `show_kubernetes_context_label`, becomes arg $4 for `show_only_kubernetes_context`. So the default value for `show_only_kubernetes_context` needs to be a non-zero string.
|
Good catch. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a bug on the
@dracula-kubernetes-context-labeloption inkubernetes_contextplugin.kubernetes_context.shis called with positional args as such:When
show_only_kubernetes_contextdefaults to "", arg $5show_kubernetes_context_label, becomes arg $4show_only_kubernetes_context. Effectively, the value of@dracula-kubernetes-context-labelis passed to the script asshow_only_kubernetes_contextinstead ofshow_kubernetes_context_labelSo the default value forshow_only_kubernetes_contextneeds to be a non-zero string.Here are screenshots showing the bug:
@dracula-kubernetes-context-labelhas no effect when@dracula-show-only-kubernetes-contextis"".@dracula-kubernetes-context-labelhas no effect when@dracula-show-only-kubernetes-contextis not set.Setting
@dracula-kubernetes-context-labelto"true"is effectively the same as setting@dracula-show-only-kubernetes-contextto"true".@dracula-kubernetes-context-labelonly takes effect when@dracula-show-only-kubernetes-contextis explicitly set to"false"or other non-zero length string other than "true".