Merged
Conversation
Grepping the output of top could sometimes return the grep process, leading to a nonsensical %CPU reading.
ethancedwards8
approved these changes
May 17, 2025
Member
|
Nice catch. Thanks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Grepping the output of top for
Cpu(s)includes a row for thegrep "Cpu(s)"process, which sometimes ends up being selected bytail -1, causing a nonsensical %CPU reading (in orange in the screenshot below).This fix uses the pattern
[C]pu(s)to exclude the search pattern in the grep process itself, a la this stackexchange https://unix.stackexchange.com/a/74186.It is still possible for the grep pattern to match
Cpu(s)in the arguments for another process, but that seems much less likely.