-
Notifications
You must be signed in to change notification settings - Fork 28
New Theming #868
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New Theming #868
Conversation
Published version: @draftbit/[email protected] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is awesome work! A few minor comments and questions, but no blockers!
packages/core/src/__tests__/components/CircularProgress.test.tsx
Outdated
Show resolved
Hide resolved
packages/core/src/__tests__/components/CircularProgress.test.tsx
Outdated
Show resolved
Hide resolved
packages/core/src/__tests__/components/CircularProgress.test.tsx
Outdated
Show resolved
Hide resolved
packages/core/src/__tests__/components/CircularProgress.test.tsx
Outdated
Show resolved
Hide resolved
Co-authored-by: needs <[email protected]>
Published version: @draftbit/[email protected] |
Published version: @draftbit/[email protected] |
Published version: @draftbit/[email protected] |
Published version: @draftbit/[email protected] |
Published version: @draftbit/[email protected] |
Published version: @draftbit/[email protected] |
Published version: @draftbit/[email protected] |
example
,packages/core
,packages/maps
, andpackages/native
are just updating old theme references to the new theme references.packages/theme
theme.colors.primary
is nowtheme.colors.branding.primary
). We'll need a migration for this.theme.colors.branding.someValue
can return a different value for ios and android)untitled.webm