Skip to content

feat: support mode modal for picker component #881

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
May 19, 2024
Merged

feat: support mode modal for picker component #881

merged 4 commits into from
May 19, 2024

Conversation

sieu-db
Copy link
Collaborator

@sieu-db sieu-db commented May 15, 2024 •
edited
Loading

Overview

Support new mode is modal picker

  • Prevent the issue concerning zIndex conflicts.
  • Introduces an enhancement to dismiss the picker by tapping outside the modal. This is crucial as it aligns with the standard user experience of modal operation.
  • Adds a feature to customize the backdrop overlay of the modal. This help user can fully customize the overlay, to make the UI behavior exactly the same as dropdown picker mode
  • ❌ This mode not supported multipicker

Existing problem

We have some problem if picker got wrap by the View

Screenshot 2024-05-15 at 21 18 30

Demo

Screen.Recording.2024-05-15.at.21.03.23.mov

@sieu-db sieu-db marked this pull request as draft May 15, 2024 14:02
@sieu-db sieu-db marked this pull request as ready for review May 15, 2024 14:18
YoussefHenna
YoussefHenna approved these changes May 19, 2024
View reviewed changes
Copy link
Collaborator

@YoussefHenna YoussefHenna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome stuff! One thing is that there is bit of duplicated code from the dropdown picker. I'll merge this to a separate branch and de-deplicate before I merge to master. But otherwise, great work!

@YoussefHenna YoussefHenna changed the base branch from master to youssef/p-4992-add-modal-support-for-dropdown-picker May 19, 2024 10:16
@YoussefHenna YoussefHenna merged commit 8715f78 into draftbit:youssef/p-4992-add-modal-support-for-dropdown-picker May 19, 2024
1 check failed
@YoussefHenna YoussefHenna mentioned this pull request May 19, 2024
Merged
YoussefHenna pushed a commit that referenced this pull request May 19, 2024
@sieu-db @YoussefHenna
feat: support mode modal for picker component (#881)
65b46f5 
* feat: add react-native select dropdown and needed interface

* feat: add modal picker component

* chore: add picker example about modal mode

* chore: clean up
YoussefHenna added a commit that referenced this pull request May 19, 2024
@YoussefHenna @sieu-db
Support modal mode on picker (#882)
6cff036 
* feat: support mode modal for picker component (#881)

* feat: add react-native select dropdown and needed interface

* feat: add modal picker component

* chore: add picker example about modal mode

* chore: clean up

* Tweaks to modal dropdown picker

---------

Co-authored-by: sieu-db <[email protected]>
YoussefHenna added a commit that referenced this pull request May 19, 2024
@YoussefHenna @sieu-db
Support modal mode on picker (49) (#883)
004a778 
* feat: support mode modal for picker component (#881)

* feat: add react-native select dropdown and needed interface

* feat: add modal picker component

* chore: add picker example about modal mode

* chore: clean up

* Tweaks to modal dropdown picker

---------

Co-authored-by: sieu-db <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YoussefHenna YoussefHenna YoussefHenna approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sieu-db @YoussefHenna