Skip to content

Revert removed shadow from Surface component #907

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 22, 2024
Merged

Revert removed shadow from Surface component #907

merged 1 commit into from
Jul 22, 2024

Conversation

YoussefHenna
Copy link
Collaborator

  • As part of the theming stuff, it seems I removed this shadow implementation by accident. Required to render a shadow for web and ios (android uses the elevation property)

@linear Linear
Copy link

linear bot commented Jul 21, 2024

P-5212 Surface Component Issue with Expo 50

@github-actions GitHub Actions
Copy link

Published version: @draftbit/[email protected]

@YoussefHenna YoussefHenna merged commit f0808ff into master Jul 22, 2024
3 checks passed
@YoussefHenna YoussefHenna deleted the youssef/p-5212-surface-component-issue-with-expo-50 branch July 22, 2024 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@YoussefHenna