add loading component #909
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Published version: @draftbit/[email protected] |
|
Published version: @draftbit/[email protected] |
|
Published version: @draftbit/[email protected] |
|
Published version: @draftbit/[email protected] |
YoussefHenna
previously approved these changes
Aug 5, 2024
Comment on lines
26
to
27
| export enum ActivityIndicatorType { | ||
| plane = "plane", |
There was a problem hiding this comment.
Suggested change
| export enum ActivityIndicatorType { | |
| plane = "plane", | |
| export enum ActivityIndicatorType { | |
| default = "default" | |
| plane = "plane", |
Let's have a default type to make it more explicit
Comment on lines
80
to
83
| color, | ||
| theme, | ||
| type, | ||
| size, |
There was a problem hiding this comment.
Suggested change
| color, | |
| theme, | |
| type, | |
| size, | |
| theme, | |
| color = theme.colors.branding.primary, | |
| type = "default", | |
| size = "small", |
Let's add default values here to be consistent with how it's in other components
| <View | ||
| style={{ | ||
| transform: [{ scale: scaleLevel }], | ||
| }} |
There was a problem hiding this comment.
The style prop should be applied here instead of the child component so we'd need to extract it from rest and apply it directly.
|
Published version: @draftbit/[email protected] |
YoussefHenna
approved these changes
Aug 6, 2024
|
Yep sure. Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Screen.Recording.2024-07-31.at.11.05.06.mov