Conversation
|
Published version: @draftbit/ui@50.2.2-132cc7.2 |
|
Published version: @draftbit/ui@50.2.2-05bcd9.2 |
|
Published version: @draftbit/ui@50.2.2-8f086c.2 |
|
Published version: @draftbit/ui@50.2.2-4b8c78.2 |
YoussefHenna
left a comment
YoussefHenna
left a comment
There was a problem hiding this comment.
Some minor comments, otherwise awesome stuff!
| export enum ActivityIndicatorType { | ||
| plane = "plane", |
There was a problem hiding this comment.
| export enum ActivityIndicatorType { | |
| plane = "plane", | |
| export enum ActivityIndicatorType { | |
| default = "default" | |
| plane = "plane", |
Let's have a default type to make it more explicit
| color, | ||
| theme, | ||
| type, | ||
| size, |
There was a problem hiding this comment.
| color, | |
| theme, | |
| type, | |
| size, | |
| theme, | |
| color = theme.colors.branding.primary, | |
| type = "default", | |
| size = "small", |
Let's add default values here to be consistent with how it's in other components
| <View | ||
| style={{ | ||
| transform: [{ scale: scaleLevel }], | ||
| }} |
There was a problem hiding this comment.
The style prop should be applied here instead of the child component so we'd need to extract it from rest and apply it directly.
|
Published version: @draftbit/ui@50.2.2-5816fd.2 |
YoussefHenna
left a comment
YoussefHenna
left a comment
There was a problem hiding this comment.
Awesome. Don't forget to make the same changes for the 49 branch
|
Yep sure. Thanks |
2 participants
Overview
Screen.Recording.2024-07-31.at.11.05.06.mov