Skip to content

Adjust height + padding for picker component #913

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Aug 11, 2024

Conversation

sieu-db
Copy link
Collaborator

@sieu-db sieu-db commented Aug 6, 2024

Overview

  • Support custom smaller size for picker component
Screenshot 2024-08-07 at 06 16 40

@sieu-db sieu-db requested a review from YoussefHenna August 6, 2024 23:17
Copy link

linear bot commented Aug 6, 2024

Copy link

github-actions bot commented Aug 6, 2024

Published version: @draftbit/[email protected]

@sieu-db sieu-db changed the title support custom smaller size for picker component Support custom smaller size for picker component Aug 7, 2024
@sieu-db sieu-db changed the title Support custom smaller size for picker component Adjust height + padding for picker component Aug 7, 2024
Copy link
Collaborator

@YoussefHenna YoussefHenna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

image

Seems there's some issue with spacing on the default sized picker

Copy link

github-actions bot commented Aug 9, 2024

Published version: @draftbit/[email protected]

@sieu-db
Copy link
Collaborator Author

sieu-db commented Aug 9, 2024

image

image

Seems there's some issue with spacing on the default sized picker

How to reproduce this one, Is it just add leftIconName in example @YoussefHenna ?
I try but it also happen on "master" branch also

@sieu-db sieu-db requested a review from YoussefHenna August 9, 2024 13:35
@YoussefHenna
Copy link
Collaborator

How to reproduce this one, Is it just add leftIconName in example @YoussefHenna ? I try but it also happen on "master" branch also

I was able to reproduce on master as well. Seems the issue comes when leftIconMode is not provided. Once you give it a value of inset or outset, it works as expected. It's not an issue from your work here, but maybe you can add a default value on TextField component for leftIconMode = "inset".

YoussefHenna
YoussefHenna previously approved these changes Aug 11, 2024
…com:draftbit/react-native-jigsaw into sieu/p-5250-support-resize-picker-component
@sieu-db
Copy link
Collaborator Author

sieu-db commented Aug 11, 2024

How to reproduce this one, Is it just add leftIconName in example @YoussefHenna ? I try but it also happen on "master" branch also

I was able to reproduce on master as well. Seems the issue comes when leftIconMode is not provided. Once you give it a value of inset or outset, it works as expected. It's not an issue from your work here, but maybe you can add a default value on TextField component for leftIconMode = "inset".

Got it, I'm added this one then we can merge this 🙏

Copy link

Published version: @draftbit/[email protected]

@sieu-db sieu-db merged commit cf94683 into master Aug 11, 2024
3 checks passed
@sieu-db sieu-db deleted the sieu/p-5250-support-resize-picker-component branch August 11, 2024 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants